Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1424313004: Remove HTMLFrameElement.prototype.getSVGDocument() (Closed)

Created:
5 years, 1 month ago by philipj_slow
Modified:
5 years, 1 month ago
Reviewers:
fs, timvolodine
CC:
blink-reviews, blink-reviews-html_chromium.org, Inactive, chromium-reviews, dglazkov+blink, vivekg_samsung, vivekg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove HTMLFrameElement.prototype.getSVGDocument() Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/_9iRam2UKBI/2sM9_G7HDQAJ BUG=549323 Committed: https://crrev.com/a452ce1dbe033f1009be002deeff75730f4370f9 Cr-Commit-Position: refs/heads/master@{#357368}

Patch Set 1 #

Patch Set 2 : android_webview/tools/WebViewShell/test/webexposed/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -34 lines) Patch
M android_webview/tools/WebViewShell/test/webexposed/global-interface-listing-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/frame-getSVGDocument.html View 1 chunk +7 lines, -19 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/frame-getSVGDocument-expected.txt View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/getsvgdocument-null.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/getsvgdocument-null-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameElement.idl View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424313004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424313004/1
5 years, 1 month ago (2015-11-02 09:08:43 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-02 11:13:55 UTC) #4
philipj_slow
PTAL
5 years, 1 month ago (2015-11-02 13:04:53 UTC) #6
fs
lgtm (What about WebViewShell expectations?)
5 years, 1 month ago (2015-11-02 13:15:27 UTC) #7
philipj_slow
On 2015/11/02 13:15:27, fs wrote: > lgtm > > (What about WebViewShell expectations?) Eh, I ...
5 years, 1 month ago (2015-11-02 13:18:43 UTC) #8
fs
On 2015/11/02 at 13:18:43, philipj wrote: > On 2015/11/02 13:15:27, fs wrote: > > lgtm ...
5 years, 1 month ago (2015-11-02 13:20:28 UTC) #9
philipj_slow
timvolodine@, please review android_webview/tools/WebViewShell/test/webexposed/global-interface-listing-expected.txt Should these be run on the bots so that it's impossible ...
5 years, 1 month ago (2015-11-02 13:21:44 UTC) #11
timvolodine
On 2015/11/02 13:21:44, philipj wrote: > timvolodine@, please review > android_webview/tools/WebViewShell/test/webexposed/global-interface-listing-expected.txt WebViewShell LGTM > > ...
5 years, 1 month ago (2015-11-02 15:05:35 UTC) #12
philipj_slow
On 2015/11/02 15:05:35, timvolodine wrote: > On 2015/11/02 13:21:44, philipj wrote: > > timvolodine@, please ...
5 years, 1 month ago (2015-11-02 15:17:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424313004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424313004/20001
5 years, 1 month ago (2015-11-02 15:17:52 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-02 16:30:41 UTC) #17
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 16:31:56 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a452ce1dbe033f1009be002deeff75730f4370f9
Cr-Commit-Position: refs/heads/master@{#357368}

Powered by Google App Engine
This is Rietveld 408576698