Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBox.h

Issue 1424313003: element.scrollIntoView only scrolls the layout viewport (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review feedback Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 407 matching lines...) Expand 10 before | Expand all | Expand 10 after
418 virtual LayoutUnit scrollTop() const; 418 virtual LayoutUnit scrollTop() const;
419 virtual LayoutUnit scrollWidth() const; 419 virtual LayoutUnit scrollWidth() const;
420 virtual LayoutUnit scrollHeight() const; 420 virtual LayoutUnit scrollHeight() const;
421 int pixelSnappedScrollWidth() const; 421 int pixelSnappedScrollWidth() const;
422 int pixelSnappedScrollHeight() const; 422 int pixelSnappedScrollHeight() const;
423 virtual void setScrollLeft(LayoutUnit); 423 virtual void setScrollLeft(LayoutUnit);
424 virtual void setScrollTop(LayoutUnit); 424 virtual void setScrollTop(LayoutUnit);
425 425
426 void scrollToOffset(const DoubleSize&, ScrollBehavior = ScrollBehaviorInstan t); 426 void scrollToOffset(const DoubleSize&, ScrollBehavior = ScrollBehaviorInstan t);
427 void scrollByRecursively(const DoubleSize& delta, ScrollOffsetClamping = Scr ollOffsetUnclamped); 427 void scrollByRecursively(const DoubleSize& delta, ScrollOffsetClamping = Scr ollOffsetUnclamped);
428 void scrollRectToVisible(const LayoutRect&, const ScrollAlignment& alignX, c onst ScrollAlignment& alignY, ScrollType = ProgrammaticScroll); 428 // If makeVisibleInVisualViewport is set, the visual viewport will be scroll ed
429 // if required to make the rect visible.
430 void scrollRectToVisible(const LayoutRect&, const ScrollAlignment& alignX, c onst ScrollAlignment& alignY, ScrollType = ProgrammaticScroll, bool makeVisibleI nVisualViewport = true);
429 431
430 LayoutRectOutsets marginBoxOutsets() const override { return m_marginBoxOuts ets; } 432 LayoutRectOutsets marginBoxOutsets() const override { return m_marginBoxOuts ets; }
431 LayoutUnit marginTop() const override { return m_marginBoxOutsets.top(); } 433 LayoutUnit marginTop() const override { return m_marginBoxOutsets.top(); }
432 LayoutUnit marginBottom() const override { return m_marginBoxOutsets.bottom( ); } 434 LayoutUnit marginBottom() const override { return m_marginBoxOutsets.bottom( ); }
433 LayoutUnit marginLeft() const override { return m_marginBoxOutsets.left(); } 435 LayoutUnit marginLeft() const override { return m_marginBoxOutsets.left(); }
434 LayoutUnit marginRight() const override { return m_marginBoxOutsets.right(); } 436 LayoutUnit marginRight() const override { return m_marginBoxOutsets.right(); }
435 void setMarginTop(LayoutUnit margin) { m_marginBoxOutsets.setTop(margin); } 437 void setMarginTop(LayoutUnit margin) { m_marginBoxOutsets.setTop(margin); }
436 void setMarginBottom(LayoutUnit margin) { m_marginBoxOutsets.setBottom(margi n); } 438 void setMarginBottom(LayoutUnit margin) { m_marginBoxOutsets.setBottom(margi n); }
437 void setMarginLeft(LayoutUnit margin) { m_marginBoxOutsets.setLeft(margin); } 439 void setMarginLeft(LayoutUnit margin) { m_marginBoxOutsets.setLeft(margin); }
438 void setMarginRight(LayoutUnit margin) { m_marginBoxOutsets.setRight(margin) ; } 440 void setMarginRight(LayoutUnit margin) { m_marginBoxOutsets.setRight(margin) ; }
(...skipping 616 matching lines...) Expand 10 before | Expand all | Expand 10 after
1055 if (UNLIKELY(inlineBoxWrapper() != nullptr)) 1057 if (UNLIKELY(inlineBoxWrapper() != nullptr))
1056 deleteLineBoxWrapper(); 1058 deleteLineBoxWrapper();
1057 } 1059 }
1058 1060
1059 ensureRareData().m_inlineBoxWrapper = boxWrapper; 1061 ensureRareData().m_inlineBoxWrapper = boxWrapper;
1060 } 1062 }
1061 1063
1062 } // namespace blink 1064 } // namespace blink
1063 1065
1064 #endif // LayoutBox_h 1066 #endif // LayoutBox_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/Element.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698