Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 1424303002: Remove unused support for NFC normalization during text encoding (Closed)

Created:
5 years, 1 month ago by jsbell
Modified:
5 years, 1 month ago
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail, jungshik at Google
Base URL:
https://chromium.googlesource.com/chromium/src.git@nfc-remove
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused support for NFC normalization during text encoding Previous CLs have updated all of the paths that were incorrectly performing normalization during text encoding, so this code is now unused. BUG=545678 R=pdr@chromium.org TBR=jochen@chromium.org Committed: https://crrev.com/859bb51120f88fd7e1b53e052be488f31dd4a926 Cr-Commit-Position: refs/heads/master@{#358360}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -54 lines) Patch
M third_party/WebKit/Source/wtf/text/StringUTF8Adaptor.h View 2 chunks +2 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/TextEncoding.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/TextEncoding.cpp View 2 chunks +0 lines, -40 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (8 generated)
jsbell
This depends on: https://codereview.chromium.org/1420483005/ https://codereview.chromium.org/1424503006/
5 years, 1 month ago (2015-10-29 19:48:49 UTC) #1
jsbell
This is ready to go now. jshin@ - please take a look?
5 years, 1 month ago (2015-11-02 23:45:17 UTC) #2
jsbell
Since this is just code deletion could you take a look at this one too, ...
5 years, 1 month ago (2015-11-04 18:56:17 UTC) #4
pdr.
On 2015/11/04 at 18:56:17, jsbell wrote: > Since this is just code deletion could you ...
5 years, 1 month ago (2015-11-06 02:55:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424303002/1
5 years, 1 month ago (2015-11-06 17:18:24 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/116342)
5 years, 1 month ago (2015-11-06 17:26:42 UTC) #10
jsbell
*sigh* wtf OWNERS; jochen@ - can you approve?
5 years, 1 month ago (2015-11-06 17:29:19 UTC) #12
pdr.
On 2015/11/06 at 17:29:19, jsbell wrote: > *sigh* wtf OWNERS; jochen@ - can you approve? ...
5 years, 1 month ago (2015-11-06 18:15:50 UTC) #13
jsbell
On 2015/11/06 18:15:50, pdr wrote: > On 2015/11/06 at 17:29:19, jsbell wrote: > > *sigh* ...
5 years, 1 month ago (2015-11-06 18:23:43 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424303002/1
5 years, 1 month ago (2015-11-06 18:24:05 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-06 18:44:10 UTC) #19
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 18:45:08 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/859bb51120f88fd7e1b53e052be488f31dd4a926
Cr-Commit-Position: refs/heads/master@{#358360}

Powered by Google App Engine
This is Rietveld 408576698