Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Issue 1424293002: Fix cached EnumLength retrieval in JSObject::NumberOfOwnProperties (Closed)

Created:
5 years, 1 month ago by Jakob Kummerow
Modified:
5 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix cached EnumLength retrieval in JSObject::NumberOfOwnProperties BUG=chromium:549162 LOG=n R=verwaest@chromium.org Committed: https://crrev.com/70a2f537f62f8a06aefb45792b4ed86acf4fa8eb Cr-Commit-Position: refs/heads/master@{#31677}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M src/objects.cc View 1 chunk +3 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-549162.js View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jakob Kummerow
5 years, 1 month ago (2015-10-29 17:25:38 UTC) #1
Toon Verwaest
lgtm
5 years, 1 month ago (2015-10-30 10:00:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424293002/1
5 years, 1 month ago (2015-10-30 10:08:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 10:35:17 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 10:35:54 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70a2f537f62f8a06aefb45792b4ed86acf4fa8eb
Cr-Commit-Position: refs/heads/master@{#31677}

Powered by Google App Engine
This is Rietveld 408576698