Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1424283002: [es6] Fix WeakMap/Set built-ins subclasssing. (Closed)

Created:
5 years, 1 month ago by Igor Sheludko
Modified:
5 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@func-subclass
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Fix WeakMap/Set built-ins subclasssing. BUG=v8:3101, v8:3330 LOG=Y Committed: https://crrev.com/208744bc1080916b437d17ecb550c2ff75d9d975 Cr-Commit-Position: refs/heads/master@{#31759}

Patch Set 1 #

Patch Set 2 : Test updated #

Patch Set 3 : Rebasing #

Patch Set 4 : Test updated once again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -1 line) Patch
M src/objects.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/es6/classes-subclass-builtins.js View 1 2 3 1 chunk +57 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1422853004 Patch 60001

Messages

Total messages: 12 (5 generated)
Igor Sheludko
PTAL
5 years, 1 month ago (2015-10-29 16:07:53 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424283002/20001
5 years, 1 month ago (2015-10-29 22:45:29 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-29 23:23:40 UTC) #6
Toon Verwaest
lgtm
5 years, 1 month ago (2015-10-30 10:09:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424283002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424283002/60001
5 years, 1 month ago (2015-11-03 17:40:23 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-11-03 17:59:39 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 18:00:19 UTC) #12
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/208744bc1080916b437d17ecb550c2ff75d9d975
Cr-Commit-Position: refs/heads/master@{#31759}

Powered by Google App Engine
This is Rietveld 408576698