Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1424273004: include what you use: errno.h in components/ (Closed)

Created:
5 years, 1 month ago by Mostyn Bramley-Moore
Modified:
5 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, asvitkine+watch_chromium.org, sadrul, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

include what you use: errno.h in components/ Adding some missing errno.h includes for errno in components/ NOPRESUBMIT=TRUE Committed: https://crrev.com/c23656ca4165383a6beebd9bec32e46cc45af489 Cr-Commit-Position: refs/heads/master@{#358522}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M components/crash/content/browser/crash_handler_host_linux.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/metrics/serialization/serialization_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
Mostyn Bramley-Moore
Here's two small include-what-you-use fixes. @rsesek: can you please look at components/crash/content/browser/crash_handler_host_linux.cc @holte: can you ...
5 years, 1 month ago (2015-11-06 23:33:54 UTC) #2
Robert Sesek
lgtm
5 years, 1 month ago (2015-11-06 23:35:46 UTC) #3
Steven Holte
lgtm
5 years, 1 month ago (2015-11-07 02:46:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424273004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424273004/1
5 years, 1 month ago (2015-11-07 08:37:56 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/116577)
5 years, 1 month ago (2015-11-07 08:44:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424273004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424273004/1
5 years, 1 month ago (2015-11-07 08:57:35 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/116580)
5 years, 1 month ago (2015-11-07 09:04:32 UTC) #12
Mostyn Bramley-Moore
The presubmit failure looks to be incorrect (Missing LGTM from an OWNER for these files: ...
5 years, 1 month ago (2015-11-07 09:12:10 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424273004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424273004/1
5 years, 1 month ago (2015-11-07 09:12:31 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-07 09:32:39 UTC) #17
commit-bot: I haz the power
5 years, 1 month ago (2015-11-07 09:33:30 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c23656ca4165383a6beebd9bec32e46cc45af489
Cr-Commit-Position: refs/heads/master@{#358522}

Powered by Google App Engine
This is Rietveld 408576698