android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java - Issue 1424263003: Reland "Use resource throttle to implement shouldOverrideUrlLoading, core change"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java

Issue 1424263003: Reland "Use resource throttle to implement shouldOverrideUrlLoading, core change" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert unnecessary change for making XHR test thread-safe (it was safe before the change). Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwContents.java ('k') | android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java b/android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java

index 5f34edcd4fd9c5ad4b1d4f2ba2898902af28512a..c1b03a17efe28c974ca2834f7b288d543b323411 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java

@@ -259,13 +259,6 @@ public class AwContentsClientBridge {

mClient.handleJsBeforeUnload(url, message, handler);

}

- @CalledByNative

- private boolean shouldOverrideUrlLoading(

- String url, boolean hasUserGesture, boolean isRedirect, boolean isMainFrame) {

- return mClient.shouldIgnoreNavigation(

- mContext, url, isMainFrame, hasUserGesture, isRedirect);

- }

void confirmJsResult(int id, String prompt) {

if (mNativeContentsClientBridge == 0) return;

nativeConfirmJsResult(mNativeContentsClientBridge, id, prompt);