android_webview/common/render_view_messages.h - Issue 1424263003: Reland "Use resource throttle to implement shouldOverrideUrlLoading, core change"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/common/render_view_messages.h

Issue 1424263003: Reland "Use resource throttle to implement shouldOverrideUrlLoading, core change" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert unnecessary change for making XHR test thread-safe (it was safe before the change). Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/aw_contents_client_bridge_base.h ('k') | android_webview/java/src/org/chromium/android_webview/AwContents.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/common/render_view_messages.h

diff --git a/android_webview/common/render_view_messages.h b/android_webview/common/render_view_messages.h

index e13c3a2b7bc0d1f4db386628affa41e328c3ebfc..91dbb5bf25ecc02daf9ca9c63955298f4e70fdcc 100644

--- a/android_webview/common/render_view_messages.h

+++ b/android_webview/common/render_view_messages.h

@@ -104,20 +104,6 @@ IPC_MESSAGE_ROUTED1(AwViewHostMsg_PageScaleFactorChanged,

IPC_MESSAGE_ROUTED1(AwViewHostMsg_OnContentsSizeChanged,

gfx::Size /* contents_size */)

-// Sent immediately before a top level navigation is initiated within Blink.

-// There are some exlusions, the most important ones are it is not sent

-// when creating a popup window, and not sent for application initiated

-// navigations. See AwContentRendererClient::HandleNavigation for all

-// cornercases. This is sent before updating the NavigationController state

-// or creating a URLRequest for the main frame resource.

-IPC_SYNC_MESSAGE_CONTROL5_1(AwViewHostMsg_ShouldOverrideUrlLoading,

- int /* render_frame_id id */,

- base::string16 /* in - url */,

- bool /* in - has_user_gesture */,

- bool /* in - is_redirect */,

- bool /* in - is_main_frame */,

- bool /* out - result */)

// Sent when a subframe is created.

IPC_MESSAGE_CONTROL2(AwViewHostMsg_SubFrameCreated,

int /* parent_render_frame_id */,