components/navigation_interception/intercept_navigation_throttle.cc - Issue 1424263003: Reland "Use resource throttle to implement shouldOverrideUrlLoading, core change"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/navigation_interception/intercept_navigation_throttle.cc

Issue 1424263003: Reland "Use resource throttle to implement shouldOverrideUrlLoading, core change" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix failing instrumentation tests (connected to userGesture and isMainFrame) Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java ('K') | « android_webview/renderer/aw_content_renderer_client.cc ('k') | content/public/renderer/content_renderer_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/navigation_interception/intercept_navigation_throttle.cc

diff --git a/components/navigation_interception/intercept_navigation_throttle.cc b/components/navigation_interception/intercept_navigation_throttle.cc

index cc256a1273e0a0889e1df2cbabd3f999c3350bbb..ded208d61887b3b9a598e582f9c6d8573ea07a3c 100644

--- a/components/navigation_interception/intercept_navigation_throttle.cc

+++ b/components/navigation_interception/intercept_navigation_throttle.cc

@@ -37,7 +37,8 @@ InterceptNavigationThrottle::CheckIfShouldIgnoreNavigation(bool is_redirect) {

navigation_handle()->GetURL(), navigation_handle()->GetReferrer(),

navigation_handle()->HasUserGesture(), navigation_handle()->IsPost(),

navigation_handle()->GetPageTransition(), is_redirect,

- navigation_handle()->IsExternalProtocol(), true);

+ navigation_handle()->IsExternalProtocol(),

+ navigation_handle()->IsInMainFrame());

bool should_ignore_navigation = should_ignore_callback_.Run(

navigation_handle()->GetWebContents(), navigation_params);