android_webview/browser/aw_contents_client_bridge_base.h - Issue 1424263003: Reland "Use resource throttle to implement shouldOverrideUrlLoading, core change"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/aw_contents_client_bridge_base.h

Issue 1424263003: Reland "Use resource throttle to implement shouldOverrideUrlLoading, core change" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix failing instrumentation tests (connected to userGesture and isMainFrame) Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/aw_content_browser_client.cc ('k') | android_webview/common/render_view_messages.h » ('j') | android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/browser/aw_contents_client_bridge_base.h

diff --git a/android_webview/browser/aw_contents_client_bridge_base.h b/android_webview/browser/aw_contents_client_bridge_base.h

index 6ac592b9c2776f7b5d0dd89d2fa582bd4b3fa191..9cd92063f0f0cad49ef9b404a050b5efff8d1ccd 100644

--- a/android_webview/browser/aw_contents_client_bridge_base.h

+++ b/android_webview/browser/aw_contents_client_bridge_base.h

@@ -62,11 +62,6 @@ class AwContentsClientBridgeBase {

const base::string16& message_text,

const content::JavaScriptDialogManager::DialogClosedCallback& callback)

= 0;

- virtual bool ShouldOverrideUrlLoading(const base::string16& url,

- bool has_user_gesture,

- bool is_redirect,

- bool is_main_frame) = 0;

};

} // namespace android_webview