Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1424253002: SkScan_Antihair: assert in debug and potentialy lost last pixels (Closed)

Created:
5 years, 1 month ago by aleksandar.stojiljkovic
Modified:
5 years, 1 month ago
Reviewers:
f(malita), reed2, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkScan_Antihair: assert in debug and potentialy lost last pixels alpha: (uint8_t) 256 is clamped to 255 before static cast to uint8_t in SkToU8. BUG=4406 Committed: https://skia.googlesource.com/skia/+/7600183ba7d8c8df6fbba1b32a73e6394216754e

Patch Set 1 #

Patch Set 2 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -1 line) Patch
M src/core/SkScan_Antihair.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M tests/RectTest.cpp View 1 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
aleksandar.stojiljkovic
5 years, 1 month ago (2015-10-28 22:02:09 UTC) #2
reed1
If you want to make this CL real, it should include a test that fails ...
5 years, 1 month ago (2015-10-29 19:04:44 UTC) #4
aleksandar.stojiljkovic
5 years, 1 month ago (2015-10-29 23:30:30 UTC) #5
reed1
nice. lgtm
5 years, 1 month ago (2015-11-02 18:54:18 UTC) #6
aleksandar.stojiljkovic
On 2015/11/02 18:54:18, reed1 wrote: > nice. > > lgtm Don't have trybot and commit ...
5 years, 1 month ago (2015-11-02 21:04:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424253002/20001
5 years, 1 month ago (2015-11-02 21:17:43 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 21:28:53 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7600183ba7d8c8df6fbba1b32a73e6394216754e

Powered by Google App Engine
This is Rietveld 408576698