Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Side by Side Diff: src/objects.h

Issue 1424233005: Fix another corner-case behavior of Object::SetSuperProperty. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove should_throw argument of SetDataProperty. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_OBJECTS_H_ 5 #ifndef V8_OBJECTS_H_
6 #define V8_OBJECTS_H_ 6 #define V8_OBJECTS_H_
7 7
8 #include <iosfwd> 8 #include <iosfwd>
9 9
10 #include "src/allocation.h" 10 #include "src/allocation.h"
(...skipping 1250 matching lines...) Expand 10 before | Expand all | Expand 10 after
1261 Handle<Object> value, ShouldThrow should_throw); 1261 Handle<Object> value, ShouldThrow should_throw);
1262 MUST_USE_RESULT static Maybe<bool> WriteToReadOnlyProperty( 1262 MUST_USE_RESULT static Maybe<bool> WriteToReadOnlyProperty(
1263 LookupIterator* it, Handle<Object> value, ShouldThrow should_throw); 1263 LookupIterator* it, Handle<Object> value, ShouldThrow should_throw);
1264 MUST_USE_RESULT static Maybe<bool> WriteToReadOnlyProperty( 1264 MUST_USE_RESULT static Maybe<bool> WriteToReadOnlyProperty(
1265 Isolate* isolate, Handle<Object> receiver, Handle<Object> name, 1265 Isolate* isolate, Handle<Object> receiver, Handle<Object> name,
1266 Handle<Object> value, ShouldThrow should_throw); 1266 Handle<Object> value, ShouldThrow should_throw);
1267 MUST_USE_RESULT static Maybe<bool> RedefineIncompatibleProperty( 1267 MUST_USE_RESULT static Maybe<bool> RedefineIncompatibleProperty(
1268 Isolate* isolate, Handle<Object> name, Handle<Object> value, 1268 Isolate* isolate, Handle<Object> name, Handle<Object> value,
1269 ShouldThrow should_throw); 1269 ShouldThrow should_throw);
1270 MUST_USE_RESULT static Maybe<bool> SetDataProperty(LookupIterator* it, 1270 MUST_USE_RESULT static Maybe<bool> SetDataProperty(LookupIterator* it,
1271 Handle<Object> value, 1271 Handle<Object> value);
1272 ShouldThrow should_throw);
1273 MUST_USE_RESULT static Maybe<bool> AddDataProperty( 1272 MUST_USE_RESULT static Maybe<bool> AddDataProperty(
1274 LookupIterator* it, Handle<Object> value, PropertyAttributes attributes, 1273 LookupIterator* it, Handle<Object> value, PropertyAttributes attributes,
1275 ShouldThrow should_throw, StoreFromKeyed store_mode); 1274 ShouldThrow should_throw, StoreFromKeyed store_mode);
1276 MUST_USE_RESULT static inline MaybeHandle<Object> GetPropertyOrElement( 1275 MUST_USE_RESULT static inline MaybeHandle<Object> GetPropertyOrElement(
1277 Handle<Object> object, Handle<Name> name, 1276 Handle<Object> object, Handle<Name> name,
1278 LanguageMode language_mode = SLOPPY); 1277 LanguageMode language_mode = SLOPPY);
1279 MUST_USE_RESULT static inline MaybeHandle<Object> GetPropertyOrElement( 1278 MUST_USE_RESULT static inline MaybeHandle<Object> GetPropertyOrElement(
1280 Handle<JSReceiver> holder, Handle<Name> name, Handle<Object> receiver, 1279 Handle<JSReceiver> holder, Handle<Name> name, Handle<Object> receiver,
1281 LanguageMode language_mode = SLOPPY); 1280 LanguageMode language_mode = SLOPPY);
1282 MUST_USE_RESULT static inline MaybeHandle<Object> GetProperty( 1281 MUST_USE_RESULT static inline MaybeHandle<Object> GetProperty(
(...skipping 9518 matching lines...) Expand 10 before | Expand all | Expand 10 after
10801 // (elements + properties) in the current level. 10800 // (elements + properties) in the current level.
10802 int levelLength_ = 0; 10801 int levelLength_ = 0;
10803 10802
10804 DISALLOW_COPY_AND_ASSIGN(KeyAccumulator); 10803 DISALLOW_COPY_AND_ASSIGN(KeyAccumulator);
10805 }; 10804 };
10806 10805
10807 } // NOLINT, false-positive due to second-order macros. 10806 } // NOLINT, false-positive due to second-order macros.
10808 } // NOLINT, false-positive due to second-order macros. 10807 } // NOLINT, false-positive due to second-order macros.
10809 10808
10810 #endif // V8_OBJECTS_H_ 10809 #endif // V8_OBJECTS_H_
OLDNEW
« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698