Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: src/heap/heap.cc

Issue 1424233002: [heap] Clean-up incrementally finalize marking. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap/incremental-marking.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index 1858cad1e38d891803970d02d1abe02efd7de08d..a76f4e3cd344564b05b1a5d3bb0275e4b41213eb 100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -776,7 +776,7 @@ void Heap::HandleGCRequest() {
}
DCHECK(FLAG_finalize_marking_incrementally);
if (!incremental_marking()->finalize_marking_completed()) {
- FinalizeIncrementalMarking("GC interrupt");
+ FinalizeIncrementalMarking("GC interrupt: finalize incremental marking");
}
}
@@ -788,8 +788,7 @@ void Heap::ScheduleIdleScavengeIfNeeded(int bytes_allocated) {
void Heap::FinalizeIncrementalMarking(const char* gc_reason) {
if (FLAG_trace_incremental_marking) {
- PrintF("[IncrementalMarking] Overapproximate weak closure (%s).\n",
- gc_reason);
+ PrintF("[IncrementalMarking] (%s).\n", gc_reason);
}
GCTracer::Scope gc_scope(tracer(), GCTracer::Scope::MC_INCREMENTAL_FINALIZE);
@@ -4095,7 +4094,7 @@ bool Heap::TryFinalizeIdleIncrementalMarking(double idle_time_in_ms) {
gc_idle_time_handler_->ShouldDoOverApproximateWeakClosure(
static_cast<size_t>(idle_time_in_ms))))) {
FinalizeIncrementalMarking(
- "Idle notification: overapproximate weak closure");
+ "Idle notification: finalize incremental marking");
return true;
} else if (incremental_marking()->IsComplete() ||
(mark_compact_collector()->marking_deque()->IsEmpty() &&
@@ -4103,7 +4102,7 @@ bool Heap::TryFinalizeIdleIncrementalMarking(double idle_time_in_ms) {
static_cast<size_t>(idle_time_in_ms), size_of_objects,
final_incremental_mark_compact_speed_in_bytes_per_ms))) {
CollectAllGarbage(current_gc_flags_,
- "idle notification: finalize incremental");
+ "idle notification: finalize incremental marking");
return true;
}
return false;
« no previous file with comments | « no previous file | src/heap/incremental-marking.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698