Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: chrome/test/android/javatests/src/org/chromium/chrome/test/util/PrerenderTestHelper.java

Issue 1424213002: Removing AtomicBoolean using ThreadUtils (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/sync/SyncTestUtil.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/android/javatests/src/org/chromium/chrome/test/util/PrerenderTestHelper.java
diff --git a/chrome/test/android/javatests/src/org/chromium/chrome/test/util/PrerenderTestHelper.java b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/PrerenderTestHelper.java
index 2a095b6592f799582800e24816048a1228ff4eca..b3e822c824d6219b911025f44802f8556304cf9e 100644
--- a/chrome/test/android/javatests/src/org/chromium/chrome/test/util/PrerenderTestHelper.java
+++ b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/PrerenderTestHelper.java
@@ -19,7 +19,7 @@ import org.chromium.chrome.test.ChromeTabbedActivityTestBase;
import org.chromium.content.browser.test.util.Criteria;
import org.chromium.content.browser.test.util.CriteriaHelper;
-import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.concurrent.Callable;
import java.util.concurrent.atomic.AtomicReference;
/**
@@ -32,14 +32,12 @@ public class PrerenderTestHelper {
private static final int MAX_NUM_REPEATS_FOR_TRAINING = 7;
private static boolean hasTabPrerenderedUrl(final Tab tab, final String url) {
- final AtomicBoolean result = new AtomicBoolean();
- ThreadUtils.runOnUiThreadBlocking(new Runnable() {
+ return ThreadUtils.runOnUiThreadBlockingNoException(new Callable<Boolean>() {
@Override
- public void run() {
- result.set(tab.hasPrerenderedUrl(url));
+ public Boolean call() {
+ return tab.hasPrerenderedUrl(url);
}
});
- return result.get();
}
/**
« no previous file with comments | « no previous file | chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/sync/SyncTestUtil.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698