chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm - Issue 14242004: Speculative fix for instant overlay crash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm

Issue 14242004: Speculative fix for instant overlay crash (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/tab_contents/instant_overlay_controller_mac.mm ('K') | « chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm

diff --git a/chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm b/chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm

index 634f456f716cf5e94946e3639863ae0349947c85..0d51a488a2be89d772839640e2206c7fdf2479d5 100644

--- a/chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm

+++ b/chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm

@@ -130,6 +130,13 @@

return instantOverlayController_.get();

}

+- (void)onWebContentsDestroyed:(content::WebContents*)webContents {

+ if (overlayContents_ == webContents) {

+ [overlayContents_->GetView()->GetNativeView() removeFromSuperview];

+ overlayContents_ = NULL;

+ }

- (NSView*)activeContainer {

return activeContainer_.get();

}