Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1567)

Unified Diff: components/cronet/android/api/src/org/chromium/net/CronetEngine.java

Issue 1424193003: [Cronet] Remove CronetEngine.Builder JSON serial/deserialization APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address Helen's comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/api/src/org/chromium/net/CronetEngine.java
diff --git a/components/cronet/android/api/src/org/chromium/net/CronetEngine.java b/components/cronet/android/api/src/org/chromium/net/CronetEngine.java
index 9316a7c0e25e02ce30f26e93e09645620fe4e0a6..aae436c7040084ead7a06176e571860d35235d47 100644
--- a/components/cronet/android/api/src/org/chromium/net/CronetEngine.java
+++ b/components/cronet/android/api/src/org/chromium/net/CronetEngine.java
@@ -53,19 +53,6 @@ public abstract class CronetEngine {
}
/**
- * Creates a config from a JSON string, which was serialized using
- * {@link #toString}.
- *
- * @param context Android {@link Context} for engine to use.
- * @param json JSON string of configuration parameters, which was
- * serialized using {@link #toString}.
- */
- public Builder(Context context, String json) throws JSONException {
- mConfig = new JSONObject(json);
- mContext = context;
- }
-
- /**
* Constructs a User-Agent string including Cronet version, and
* application name and version.
*
@@ -336,8 +323,7 @@ public abstract class CronetEngine {
/**
* Get JSON string representation of the builder.
xunjieli 2015/10/29 15:55:49 nit: s/Get/Gets.
pauljensen 2015/10/29 16:20:48 Done, and added an "a" afterwards.
*/
- @Override
- public String toString() {
+ String toJSONString() {
return mConfig.toString();
}

Powered by Google App Engine
This is Rietveld 408576698