Replace glyph find and position with common code for the gpu bitmap case.

Replace glyph find and position with common code for the gpu bitmap case.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/9be5ff6f9871ef22740094e7c25dd67329a73d20

[herb_g, 2015-11-09 22:21:07]

Description was changed from

==========
Replace glyph find and position with common code for the gpu bitmap case.

BUG=skia:
==========

to

==========
Replace glyph find and position with common code for the gpu bitmap case.

BUG=skia:
==========

[herb_g, 2015-11-09 22:21:07]

herb@google.com changed reviewers:
+ joshualitt@google.com, mtklein@google.com

[mtklein, 2015-11-09 22:24:45]

https://codereview.chromium.org/1424173005/diff/40001/src/gpu/GrAtlasTextCont...
File src/gpu/GrAtlasTextContext.cpp (right):

https://codereview.chromium.org/1424173005/diff/40001/src/gpu/GrAtlasTextCont...
src/gpu/GrAtlasTextContext.cpp:937: if
(!SkFindAndPlaceGlyph::SpecializedProcessPosText(
Now I'm thinking we should probably move SpecializedProcessPosText() into
ProcessPosText().

No need for all these sites to know or care about the existence of the Blink
specialization.

That'll also let us write processOneGlyph inline again, if you like.

[herb_g, 2015-11-09 22:38:01]

https://codereview.chromium.org/1424173005/diff/40001/src/gpu/GrAtlasTextCont...
File src/gpu/GrAtlasTextContext.cpp (right):

https://codereview.chromium.org/1424173005/diff/40001/src/gpu/GrAtlasTextCont...
src/gpu/GrAtlasTextContext.cpp:937: if
(!SkFindAndPlaceGlyph::SpecializedProcessPosText(
On 2015/11/09 22:24:45, mtklein wrote:
> Now I'm thinking we should probably move SpecializedProcessPosText() into
> ProcessPosText().
> 
> No need for all these sites to know or care about the existence of the Blink
> specialization.
> 
> That'll also let us write processOneGlyph inline again, if you like.

I think we want to leave them separate for now, because we don't need the
specialization at all in the printing code.

[mtklein, 2015-11-10 00:23:54]

On 2015/11/09 at 22:38:01, herb wrote:
>
https://codereview.chromium.org/1424173005/diff/40001/src/gpu/GrAtlasTextCont...
> File src/gpu/GrAtlasTextContext.cpp (right):
> 
>
https://codereview.chromium.org/1424173005/diff/40001/src/gpu/GrAtlasTextCont...
> src/gpu/GrAtlasTextContext.cpp:937: if
(!SkFindAndPlaceGlyph::SpecializedProcessPosText(
> On 2015/11/09 22:24:45, mtklein wrote:
> > Now I'm thinking we should probably move SpecializedProcessPosText() into
> > ProcessPosText().
> > 
> > No need for all these sites to know or care about the existence of the Blink
> > specialization.
> > 
> > That'll also let us write processOneGlyph inline again, if you like.
> 
> I think we want to leave them separate for now, because we don't need the
specialization at all in the printing code.

Really?  Which sites will we skip?

[herb_g, 2015-11-10 15:48:36]

special case rolled into general

[herb_g, 2015-11-10 15:50:06]

After thinking about it, I don't care about the special case as much as I want a
single simple API. Rolling the special case in simplifies the API. 

PTAL

[herb_g, 2015-11-10 16:49:04]

The CQ bit was checked by herb@google.com

[commit-bot: I haz the power, 2015-11-10 16:49:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424173005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424173005/60001

[commit-bot: I haz the power, 2015-11-10 16:49:16]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-11-10 22:49 UTC

[commit-bot: I haz the power, 2015-11-10 16:50:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-10 16:50:26]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[herb_g, 2015-11-10 17:14:18]

keep blitter choose alive

[herb_g, 2015-11-10 17:14:36]

The CQ bit was checked by herb@google.com

[commit-bot: I haz the power, 2015-11-10 17:14:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424173005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424173005/80001

[commit-bot: I haz the power, 2015-11-10 22:49:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-10 22:49:07]

No LGTM from a valid reviewer yet. Please ask for an LGTM from a
full Skia committer

[mtklein, 2015-11-11 17:42:25]

lgtm

Is there a good default GPU trybot?

[mtklein, 2015-11-11 18:36:58]

On 2015/11/11 at 17:42:25, mtklein wrote:
> lgtm
> 
> Is there a good default GPU trybot?

FYI, I triggered a trybot and it looks fine there:
https://gold.skia.org/search2?issue=1424173005&unt=true&query=source_type%3Dg...

Just one new image, which I think is a flaky test.

[herb_g, 2015-11-11 19:18:03]

The CQ bit was checked by herb@google.com

[commit-bot: I haz the power, 2015-11-11 19:18:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424173005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424173005/80001

[commit-bot: I haz the power, 2015-11-11 19:30:18]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/9be5ff6f9871ef22740094e7c25dd67329a73d20