Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: src/ic/arm64/handler-compiler-arm64.cc

Issue 1424153003: VectorICs: Remove --vector-stores flag. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Response to Hannes comment. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/arm64/access-compiler-arm64.cc ('k') | src/ic/arm64/ic-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM64 5 #if V8_TARGET_ARCH_ARM64
6 6
7 #include "src/ic/call-optimization.h" 7 #include "src/ic/call-optimization.h"
8 #include "src/ic/handler-compiler.h" 8 #include "src/ic/handler-compiler.h"
9 #include "src/ic/ic.h" 9 #include "src/ic/ic.h"
10 #include "src/isolate-inl.h" 10 #include "src/isolate-inl.h"
(...skipping 282 matching lines...) Expand 10 before | Expand all | Expand 10 after
293 } 293 }
294 294
295 // Restore context register. 295 // Restore context register.
296 __ Ldr(cp, MemOperand(fp, StandardFrameConstants::kContextOffset)); 296 __ Ldr(cp, MemOperand(fp, StandardFrameConstants::kContextOffset));
297 } 297 }
298 __ Ret(); 298 __ Ret();
299 } 299 }
300 300
301 301
302 static void StoreIC_PushArgs(MacroAssembler* masm) { 302 static void StoreIC_PushArgs(MacroAssembler* masm) {
303 if (FLAG_vector_stores) { 303 __ Push(StoreDescriptor::ReceiverRegister(), StoreDescriptor::NameRegister(),
304 __ Push(StoreDescriptor::ReceiverRegister(), 304 StoreDescriptor::ValueRegister(),
305 StoreDescriptor::NameRegister(), StoreDescriptor::ValueRegister(), 305 VectorStoreICDescriptor::SlotRegister(),
306 VectorStoreICDescriptor::SlotRegister(), 306 VectorStoreICDescriptor::VectorRegister());
307 VectorStoreICDescriptor::VectorRegister());
308 } else {
309 __ Push(StoreDescriptor::ReceiverRegister(),
310 StoreDescriptor::NameRegister(), StoreDescriptor::ValueRegister());
311 }
312 } 307 }
313 308
314 309
315 void NamedStoreHandlerCompiler::GenerateSlow(MacroAssembler* masm) { 310 void NamedStoreHandlerCompiler::GenerateSlow(MacroAssembler* masm) {
316 StoreIC_PushArgs(masm); 311 StoreIC_PushArgs(masm);
317 312
318 // The slow case calls into the runtime to complete the store without causing 313 // The slow case calls into the runtime to complete the store without causing
319 // an IC miss that would otherwise cause a transition to the generic stub. 314 // an IC miss that would otherwise cause a transition to the generic stub.
320 __ TailCallRuntime(Runtime::kStoreIC_Slow, FLAG_vector_stores ? 5 : 3, 1); 315 __ TailCallRuntime(Runtime::kStoreIC_Slow, 5, 1);
321 } 316 }
322 317
323 318
324 void ElementHandlerCompiler::GenerateStoreSlow(MacroAssembler* masm) { 319 void ElementHandlerCompiler::GenerateStoreSlow(MacroAssembler* masm) {
325 ASM_LOCATION("ElementHandlerCompiler::GenerateStoreSlow"); 320 ASM_LOCATION("ElementHandlerCompiler::GenerateStoreSlow");
326 StoreIC_PushArgs(masm); 321 StoreIC_PushArgs(masm);
327 322
328 // The slow case calls into the runtime to complete the store without causing 323 // The slow case calls into the runtime to complete the store without causing
329 // an IC miss that would otherwise cause a transition to the generic stub. 324 // an IC miss that would otherwise cause a transition to the generic stub.
330 __ TailCallRuntime(Runtime::kKeyedStoreIC_Slow, FLAG_vector_stores ? 5 : 3, 325 __ TailCallRuntime(Runtime::kKeyedStoreIC_Slow, 5, 1);
331 1);
332 } 326 }
333 327
334 328
335 #undef __ 329 #undef __
336 #define __ ACCESS_MASM(masm()) 330 #define __ ACCESS_MASM(masm())
337 331
338 332
339 Handle<Code> NamedLoadHandlerCompiler::CompileLoadGlobal( 333 Handle<Code> NamedLoadHandlerCompiler::CompileLoadGlobal(
340 Handle<PropertyCell> cell, Handle<Name> name, bool is_configurable) { 334 Handle<PropertyCell> cell, Handle<Name> name, bool is_configurable) {
341 Label miss; 335 Label miss;
(...skipping 459 matching lines...) Expand 10 before | Expand all | Expand 10 after
801 // Return the generated code. 795 // Return the generated code.
802 return GetCode(kind(), Code::FAST, name); 796 return GetCode(kind(), Code::FAST, name);
803 } 797 }
804 798
805 799
806 #undef __ 800 #undef __
807 } // namespace internal 801 } // namespace internal
808 } // namespace v8 802 } // namespace v8
809 803
810 #endif // V8_TARGET_ARCH_IA32 804 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ic/arm64/access-compiler-arm64.cc ('k') | src/ic/arm64/ic-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698