Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(5)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: test/codegen/varargs.dart
Issue
1424133007
:
Compile package:js.{rest, spread} helpers (Closed)
Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Use freshly released version 0.6.0-beta.6 of package:js ran formatter
Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
lib/src/codegen/js_codegen.dart
lib/src/codegen/js_interop.dart
lib/src/compiler.dart
pubspec.yaml
test/codegen/expect/js/src/varargs.js
test/codegen/expect/js/src/varargs.txt
test/codegen/expect/varargs.js
test/codegen/expect/varargs.txt
test/codegen/varargs.dart
tool/input_sdk/private/js_helper.dart
tool/sdk_expected_errors.txt
View unified diff
|
Download patch
« no previous file with comments
|
« test/codegen/expect/varargs.txt
('k') |
tool/input_sdk/private/js_helper.dart »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
import 'package:js/src/varargs.dart' as js;
2
import 'package:js/src/varargs.dart' show rest, spread;
3
4
varargsTest(x, @js.rest others) {
5
var args = [1, others];
6
x.call(js.spread(args));
7
}
8
9
varargsTest2(x, @rest others) {
10
var args = [1, others];
11
x.call(spread(args));
12
}
OLD
NEW
« no previous file with comments
|
« test/codegen/expect/varargs.txt
('k') |
tool/input_sdk/private/js_helper.dart »
('j') |
no next file with comments »
Issue 1424133007: Compile package:js.{rest, spread} helpers (Closed)
Created 5 years, 1 month ago by ochafik
Modified 5 years, 1 month ago
Reviewers: Jennifer Messerly, Jacob
Base URL: git@github.com:dart-lang/dev_compiler.git@master
Comments: 0
This is Rietveld
408576698
Chromium Code Reviews
Issue 1424133007:
Compile package:js.{rest, spread} helpers (Closed)
Base URL: git@github.com:dart-lang/dev_compiler.git@master