Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Issue 1424133007: Compile package:js.{rest, spread} helpers (Closed)

Created:
5 years, 1 month ago by ochafik
Modified:
5 years, 1 month ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Compile package:js.{rest, spread} helpers. Note: need new package:js release before merging this in (https://github.com/dart-lang/sdk/issues/24623). Maybe it's time to think again about sneaking JsName + JsPeerInterface into it? (https://github.com/dart-lang/dev_compiler/issues/135) BUG=https://github.com/dart-lang/dev_compiler/issues/310 R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/79e9804af0a12a8cc10fc93c8415668b1619ffa2

Patch Set 1 #

Patch Set 2 : Use freshly released version 0.6.0-beta.6 of package:js ran formatter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -22 lines) Patch
M lib/src/codegen/js_codegen.dart View 1 10 chunks +17 lines, -15 lines 0 comments Download
A lib/src/codegen/js_interop.dart View 1 1 chunk +31 lines, -0 lines 0 comments Download
M lib/src/compiler.dart View 1 1 chunk +5 lines, -3 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -0 lines 0 comments Download
A test/codegen/expect/js/src/varargs.js View 1 1 chunk +23 lines, -0 lines 0 comments Download
A test/codegen/expect/js/src/varargs.txt View 1 chunk +1 line, -0 lines 0 comments Download
A test/codegen/expect/varargs.js View 1 1 chunk +20 lines, -0 lines 0 comments Download
A test/codegen/expect/varargs.txt View 1 chunk +1 line, -0 lines 0 comments Download
A test/codegen/varargs.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M tool/input_sdk/private/js_helper.dart View 2 chunks +1 line, -2 lines 0 comments Download
M tool/sdk_expected_errors.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ochafik
Hi guys, prepping up for rest+spread, WDYT?
5 years, 1 month ago (2015-10-29 16:07:23 UTC) #3
Jennifer Messerly
LGTM! I dunno about the version stuff ... maybe Jacob knows? I'd be totally fine ...
5 years, 1 month ago (2015-10-29 16:34:41 UTC) #4
Jennifer Messerly
On 2015/10/29 16:34:41, John Messerly wrote: > LGTM! > > I dunno about the version ...
5 years, 1 month ago (2015-10-29 16:35:12 UTC) #5
ochafik
On 2015/10/29 16:35:12, John Messerly wrote: > On 2015/10/29 16:34:41, John Messerly wrote: > > ...
5 years, 1 month ago (2015-10-29 17:44:19 UTC) #6
Jennifer Messerly
lgtm * 2
5 years, 1 month ago (2015-10-29 17:49:27 UTC) #7
ochafik
5 years, 1 month ago (2015-10-29 18:44:15 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
79e9804af0a12a8cc10fc93c8415668b1619ffa2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698