Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 142413014: Use isFinishedParsingChildren() in HTMLMediaElement (Closed)

Created:
6 years, 10 months ago by philipj_slow
Modified:
6 years, 10 months ago
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Visibility:
Public.

Description

Use isFinishedParsingChildren() in HTMLMediaElement Remove HTMLMediaElement::m_parsingInProgress. There is no runtime change, as isFinishedParsingChildren() is true per default, even for script-created elements, and only returns false between the beginParsingChildren() and finishParsingChildren(). BUG=341414 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166645

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -21 lines) Patch
M Source/core/html/HTMLAudioElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLAudioElement.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/html/HTMLMediaElement.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 4 chunks +2 lines, -4 lines 0 comments Download
M Source/core/html/HTMLTagNames.in View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLVideoElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLVideoElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
6 years, 10 months ago (2014-02-06 12:11:00 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 10 months ago (2014-02-06 17:06:07 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 10 months ago (2014-02-06 17:07:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/142413014/1
6 years, 10 months ago (2014-02-06 17:07:30 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-06 19:34:32 UTC) #5
Message was sent while issue was closed.
Change committed as 166645

Powered by Google App Engine
This is Rietveld 408576698