Ensure that CAOpenGLLayer uses the dGPU when appropriate.

Ensure that CAOpenGLLayer uses the dGPU when appropriate.

It is necessary that the context created by copyCGLContextForPixelFormat
have a pixel format compatible with the one created by
copyCGLPixelFormatForDisplayMask. In particular, make
copyCGLPixelFormatForDisplayMask create the CGL equivalent of the pixel
format created in CompositingIOSurfaceContext.

BUG=338925
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247925

[ccameron, 2014-01-29 09:31:29]

ptal. Thanks for the idea of looking at the WebKit source.

[ccameron, 2014-01-30 00:28:09]

Adding thakis (kbr is OOO for a while).

[Nico, 2014-01-30 01:56:23]

lgtm!

https://codereview.chromium.org/142413008/diff/20001/content/browser/renderer...
File content/browser/renderer_host/compositing_iosurface_layer_mac.mm (right):

https://codereview.chromium.org/142413008/diff/20001/content/browser/renderer...
content/browser/renderer_host/compositing_iosurface_layer_mac.mm:76: GLint npix
= 0;
nit: npix isn't very style guide conforming ;-)

[ccameron, 2014-01-30 06:37:29]

Thanks!

https://codereview.chromium.org/142413008/diff/20001/content/browser/renderer...
File content/browser/renderer_host/compositing_iosurface_layer_mac.mm (right):

https://codereview.chromium.org/142413008/diff/20001/content/browser/renderer...
content/browser/renderer_host/compositing_iosurface_layer_mac.mm:76: GLint npix
= 0;
On 2014/01/30 01:56:23, Nico wrote:
> nit: npix isn't very style guide conforming ;-)

Done. I should stop copy-pasting functions directly from the man pages.

[commit-bot: I haz the power, 2014-01-30 06:42:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ccameron@chromium.org/142413008/40001

[commit-bot: I haz the power, 2014-01-30 08:05:28]

Retried try job too often on android_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[commit-bot: I haz the power, 2014-01-30 08:08:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ccameron@chromium.org/142413008/40001

[commit-bot: I haz the power, 2014-01-30 10:34:45]

Change committed as 247925