Issue 142413005: Add an empty message to the notification center.

Issue 142413005: Add an empty message to the notification center. (Closed)

Created:
6 years, 10 months ago by dewittj

Modified:
6 years, 10 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add an empty message to the notification center. This will now match the UI on Windows and ChromeOS. BUG=284556 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247981

Patch Set 2 : Adds a test and fixes others. #

Patch Set 3 : Removes views changes for now. #

Total comments: 6

Patch Set 4 : Address rsesek's comments #

Patch Set 5 : Adds one more nit fix. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+105 lines, -18 lines)			Patch
M	ui/message_center/cocoa/tray_view_controller.h	View	1 2 3	2 chunks	+8 lines, -0 lines	0 comments	Download
M	ui/message_center/cocoa/tray_view_controller.mm	View	1 2 3 4	4 chunks	+61 lines, -15 lines	0 comments	Download
M	ui/message_center/cocoa/tray_view_controller_unittest.mm	View	1	3 chunks	+34 lines, -2 lines	0 comments	Download
M	ui/message_center/message_center_style.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	ui/message_center/views/message_center_view.cc	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

dewittj

PTAL, adds the "Nothing to see here, move along" text to the center of a ...

6 years, 10 months ago (2014-01-29 01:49:08 UTC) #1

Robert Sesek

https://codereview.chromium.org/142413005/diff/40001/ui/message_center/cocoa/tray_view_controller.h File ui/message_center/cocoa/tray_view_controller.h (right): https://codereview.chromium.org/142413005/diff/40001/ui/message_center/cocoa/tray_view_controller.h#newcode49 ui/message_center/cocoa/tray_view_controller.h:49: base::scoped_nsobject<NSBox> divider_; Comment please. https://codereview.chromium.org/142413005/diff/40001/ui/message_center/cocoa/tray_view_controller.h#newcode168 ui/message_center/cocoa/tray_view_controller.h:168: - (NSTextField*)emptyDescription; nit: ...

6 years, 10 months ago (2014-01-29 16:30:39 UTC) #2

dewittj

https://codereview.chromium.org/142413005/diff/40001/ui/message_center/cocoa/tray_view_controller.h File ui/message_center/cocoa/tray_view_controller.h (right): https://codereview.chromium.org/142413005/diff/40001/ui/message_center/cocoa/tray_view_controller.h#newcode49 ui/message_center/cocoa/tray_view_controller.h:49: base::scoped_nsobject<NSBox> divider_; On 2014/01/29 16:30:39, rsesek wrote: > Comment ...

6 years, 10 months ago (2014-01-29 21:52:25 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/142413005/70001

6 years, 10 months ago (2014-01-29 22:00:58 UTC) #5

commit-bot: I haz the power

Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=43331

6 years, 10 months ago (2014-01-30 09:31:47 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/142413005/70001

6 years, 10 months ago (2014-01-30 15:23:53 UTC) #7

commit-bot: I haz the power

6 years, 10 months ago (2014-01-30 17:43:42 UTC) #9

Message was sent while issue was closed.

CQ bit was unchecked on CL. Ignoring.

Expand Messages | Collapse Messages