Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 14241017: Make a metaprogramming hack more C++11-compatible (Closed)

Created:
7 years, 8 months ago by yurys
Modified:
7 years, 8 months ago
CC:
blink-reviews, jeez, abarth-chromium
Visibility:
Public.

Description

Make a metaprogramming hack more C++11-compatible This is a refined version of https://codereview.chromium.org/13824006/ by @thakis which was reverted due to compilation errors on Windows. Some classes have private "operator delete"s, which causes their destructors to be deleted in C++11. Clang's r178563 implemented this rule better, and as a result using these classes with memory instrumentation causes a compile error. To unblock the clang roll, give the metaprogramming helper class an explicit nondeleted destructor. (This is just a workaround, not a permanent fix, see bug.) See also http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20130415/078311.html TBR=thakis BUG=233473 TEST=Stuff still builds in C++11 mode after the next clang roll. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148715

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M Source/wtf/MemoryInstrumentation.h View 1 chunk +5 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yurys
7 years, 8 months ago (2013-04-19 09:10:29 UTC) #1
loislo
lgtm
7 years, 8 months ago (2013-04-19 09:57:49 UTC) #2
yurys
7 years, 8 months ago (2013-04-19 10:05:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r148715 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698