Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14241013: Fix uninitialized data member in Widget::InitParams. (Closed)

Created:
7 years, 8 months ago by tapted
Modified:
7 years, 8 months ago
CC:
chromium-reviews, tfarina, ben+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix uninitialized data member in Widget::InitParams. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195430

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/views/widget/widget.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
tapted
Hi ben, I came across this while trying to get to the bottom of http://crbug.com/231687 ...
7 years, 8 months ago (2013-04-19 11:43:43 UTC) #1
Ben Goodger (Google)
lgtm
7 years, 8 months ago (2013-04-19 16:21:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/14241013/1
7 years, 8 months ago (2013-04-19 22:32:05 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-19 23:11:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/14241013/1
7 years, 8 months ago (2013-04-20 00:38:44 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 02:48:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/14241013/1
7 years, 8 months ago (2013-04-20 09:00:16 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 09:07:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/14241013/1
7 years, 8 months ago (2013-04-21 23:06:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/14241013/1
7 years, 8 months ago (2013-04-21 23:06:23 UTC) #10
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-21 23:30:31 UTC) #11
tapted
7 years, 8 months ago (2013-04-22 02:04:54 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 manually as r195430 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698