Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: utils/tests/pub/install/hosted/cached_pubspec_test.dart

Issue 14241005: Use the cached pubspec if possible for describing hosted packages. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Redo after realizing SystemCache already has this logic. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/tests/pub/command_line_config.dart ('k') | utils/tests/pub/test_pub.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/tests/pub/install/hosted/cached_pubspec_test.dart
diff --git a/utils/tests/pub/install/hosted/cached_pubspec_test.dart b/utils/tests/pub/install/hosted/cached_pubspec_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..c30120607f3c507453c4a28010b2089a23f20446
--- /dev/null
+++ b/utils/tests/pub/install/hosted/cached_pubspec_test.dart
@@ -0,0 +1,43 @@
+// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+library pub_tests;
+
+import 'package:pathos/path.dart' as path;
+import 'package:scheduled_test/scheduled_test.dart';
+
+import '../../../../pub/io.dart';
+import '../../descriptor.dart' as d;
+import '../../test_pub.dart';
+
+main() {
+ initConfig();
+
+ integration('does not request a pubspec for a cached package', () {
+ servePackages([packageMap("foo", "1.2.3")]);
+
+ d.appDir([dependencyMap("foo", "1.2.3")]).create();
+
+ // Run install once so it gets cached.
+ schedulePub(args: ['install'],
+ output: new RegExp("Dependencies installed!\$"));
+
+ // Clear the cache. We don't care about anything that was served during
+ // the initial install.
+ getRequestedPaths();
+
+ d.cacheDir({"foo": "1.2.3"}).validate();
+ d.packagesDir({"foo": "1.2.3"}).validate();
+
+ // Run the solver again now that it's cached.
+ schedulePub(args: ['install'],
+ output: new RegExp("Dependencies installed!\$"));
+
+ // The update should not have requested the pubspec since it's installed
+ // locally already.
+ getRequestedPaths().then((paths) {
+ expect(paths, isNot(contains("packages/foo/versions/1.2.3.yaml")));
+ });
+ });
+}
« no previous file with comments | « utils/tests/pub/command_line_config.dart ('k') | utils/tests/pub/test_pub.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698