Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: utils/pub/hosted_source.dart

Issue 14241005: Use the cached pubspec if possible for describing hosted packages. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Redo after realizing SystemCache already has this logic. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | utils/pub/package.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/pub/hosted_source.dart
diff --git a/utils/pub/hosted_source.dart b/utils/pub/hosted_source.dart
index bd017e667a61f48e912f40600dcbede85071d10a..866936237b43fb0b27ec6456db208450b30eba28 100644
--- a/utils/pub/hosted_source.dart
+++ b/utils/pub/hosted_source.dart
@@ -49,11 +49,16 @@ class HostedSource extends Source {
/// Downloads and parses the pubspec for a specific version of a package that
/// is available from the site.
Future<Pubspec> describe(PackageId id) {
+ // Request it from the server.
var url = _makeVersionUrl(id, (server, package, version) =>
"$server/packages/$package/versions/$version.yaml");
log.io("Describe package at $url.");
return httpClient.read(url).then((yaml) {
+ // TODO(rnystrom): After this is pulled down, we could place it in
+ // a secondary cache of just pubspecs. This would let us have a
+ // persistent cache for pubspecs for packages that haven't actually
+ // been installed.
return new Pubspec.parse(null, yaml, systemCache.sources);
}).catchError((ex) {
var parsed = _parseDescription(id.description);
@@ -122,11 +127,11 @@ class HostedSource extends Source {
var cacheDir = path.join(systemCacheRoot,
_getSourceDirectory(_defaultUrl));
if (!dirExists(cacheDir)) return [];
-
+
return listDir(path.join(cacheDir)).map((entry) =>
new Package.load(null, entry, systemCache.sources)).toList();
}
-
+
/// When an error occurs trying to read something about [package] from [url],
/// this tries to translate into a more user friendly error message. Always
/// throws an error, either the original one or a better one.
« no previous file with comments | « no previous file | utils/pub/package.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698