Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1424093002: Add shared mutexes to the direct write cache code to get better parallelism. (Closed)

Created:
5 years, 1 month ago by herb_g
Modified:
5 years, 1 month ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add shared mutexes to the direct write cache code to get better parallelism. BUG=547182 Committed: https://skia.googlesource.com/skia/+/6440f0b09ede274f93131eebb3ef49e73dfb2b9c

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix l2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -21 lines) Patch
M src/ports/SkScalerContext_win_dw.cpp View 1 7 chunks +31 lines, -21 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424093002/1
5 years, 1 month ago (2015-10-27 19:49:58 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-27 20:01:06 UTC) #6
herb_g
5 years, 1 month ago (2015-10-27 20:26:18 UTC) #7
mtklein
lgtm
5 years, 1 month ago (2015-10-27 20:28:46 UTC) #8
mtklein
https://codereview.chromium.org/1424093002/diff/1/src/ports/SkScalerContext_win_dw.cpp File src/ports/SkScalerContext_win_dw.cpp (right): https://codereview.chromium.org/1424093002/diff/1/src/ports/SkScalerContext_win_dw.cpp#newcode435 src/ports/SkScalerContext_win_dw.cpp:435: Shared l2(DWriteFactoryMutex); Shared l(...) ?
5 years, 1 month ago (2015-10-27 20:29:42 UTC) #9
bungeman-skia
Other than the 'l2', lgtm.
5 years, 1 month ago (2015-10-27 20:39:32 UTC) #10
herb_g
Fixed the l2 issue.
5 years, 1 month ago (2015-10-27 21:26:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424093002/20001
5 years, 1 month ago (2015-10-27 21:26:33 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 21:37:03 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/6440f0b09ede274f93131eebb3ef49e73dfb2b9c

Powered by Google App Engine
This is Rietveld 408576698