Issue 1424083004: Fix an error message

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1424083004: Fix an error message (Closed)

Created:
5 years, 1 month ago by scroggo_chromium

Modified:
5 years, 1 month ago

Reviewers:
msarett, scroggo

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Fix an error message Remove double negative. Also, change another error message to be slightly (meaningfully) different so I can find the right one based on the log. Committed: https://skia.googlesource.com/skia/+/6bd9c2101973f260c98e1cb7f2afa5bd2332133e

Patch Set 1 #

Total comments: 1

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	dm/DMSrcSink.cpp	View		2 chunks	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

msarett

lgtm https://codereview.chromium.org/1424083004/diff/1/dm/DMSrcSink.cpp File dm/DMSrcSink.cpp (left): https://codereview.chromium.org/1424083004/diff/1/dm/DMSrcSink.cpp#oldcode187 dm/DMSrcSink.cpp:187: return "Cannot not decode region.\n"; Haha

5 years, 1 month ago (2015-11-03 21:22:51 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424083004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424083004/1

5 years, 1 month ago (2015-11-03 21:32:09 UTC) #5

commit-bot: I haz the power

5 years, 1 month ago (2015-11-04 12:28:57 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6bd9c2101973f260c98e1cb7f2afa5bd2332133e

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages