components/scheduler/renderer/task_cost_estimator.h - Issue 1424053002: Adds a flag to support "Virtual Time" to the blink scheduler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/scheduler/renderer/task_cost_estimator.h

Issue 1424053002: Adds a flag to support "Virtual Time" to the blink scheduler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Another try Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/scheduler/child/virtual_time_tqm_delegate.h ('K') | « components/scheduler/renderer/renderer_scheduler_impl_unittest.cc ('k') | components/scheduler/renderer/task_cost_estimator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/scheduler/renderer/task_cost_estimator.h

diff --git a/components/scheduler/renderer/task_cost_estimator.h b/components/scheduler/renderer/task_cost_estimator.h

index 7fe68db67e4e734edee79520e21605df3ce565ad..fa0f4c4897eee39e24c9670a662fa39880fc7b09 100644

--- a/components/scheduler/renderer/task_cost_estimator.h

+++ b/components/scheduler/renderer/task_cost_estimator.h

@@ -20,7 +20,9 @@ namespace scheduler {

class SCHEDULER_EXPORT TaskCostEstimator

: public base::MessageLoop::TaskObserver {

public:

- TaskCostEstimator(int sample_count, double estimation_percentile);

+ TaskCostEstimator(base::TickClock* time_source,

+ int sample_count,

+ double estimation_percentile);

~TaskCostEstimator() override;

base::TimeDelta expected_task_duration() const;

@@ -31,11 +33,9 @@ class SCHEDULER_EXPORT TaskCostEstimator

void Clear();

- void SetTimeSourceForTesting(scoped_ptr<base::TickClock> time_source);

private:

cc::RollingTimeDeltaHistory rolling_time_delta_history_;

- scoped_ptr<base::TickClock> time_source_;

+ base::TickClock* time_source_; // NOT OWNED

int outstanding_task_count_;

double estimation_percentile_;

base::TimeTicks task_start_time_;