components/scheduler/common/scheduler_switches.cc - Issue 1424053002: Adds a flag to support "Virtual Time" to the blink scheduler

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/scheduler/common/scheduler_switches.cc

Issue 1424053002: Adds a flag to support "Virtual Time" to the blink scheduler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Helps if I upload the right files ;) Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/scheduler/child/webthread_impl_for_worker_scheduler.cc ('K') | « components/scheduler/common/scheduler_switches.h ('k') | components/scheduler/ppapi/webthread_impl_for_ppapi.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "components/scheduler/common/scheduler_switches.h"

	6

	7 namespace scheduler {

	8 namespace switches {

	9

	10 // Enable Virtualized time where the Render thread's time source skips forward

	11 // to the next scheduled delayed time if there is no more non-delayed work to be

	12 // done. This switch is intended only for use in headless mode.
	Sami 2015/10/30 11:11:20 There's nothing headless-mode specific here so per There's nothing headless-mode specific here so perhaps we don't need to mention it? By the way, how do timers in background tabs work with virtualized time? It'll be as if the throttling isn't there, right? Just thinking about crbug.com/485425 in the context of this. Incidentally virtual time will nix the 1 ms setTimeout() clamping too. alex clarke (OOO till 29th) 2015/10/30 12:12:25 Not entirely no. Timer alignment will still happe Show quoted text On 2015/10/30 11:11:20, Sami wrote: > There's nothing headless-mode specific here so perhaps we don't need to mention > it? > > By the way, how do timers in background tabs work with virtualized time? It'll > be as if the throttling isn't there, right? Not entirely no. Timer alignment will still happen but when DoWork runs out of things to do virtual time will fast forward to the next timer, whatever that happens to be. Show quoted text > Just thinking about crbug.com/485425 in the context of this. Pretty sure this isn't what they want there. Show quoted text > Incidentally virtual time will nix the 1 ms setTimeout() clamping too. Right. Sami 2015/10/30 14:09:50 Right, so essentially with virtual time there's no Show quoted text On 2015/10/30 12:12:25, alexclarke1 wrote: > On 2015/10/30 11:11:20, Sami wrote: > > There's nothing headless-mode specific here so perhaps we don't need to > mention > > it? > > > > By the way, how do timers in background tabs work with virtualized time? It'll > > be as if the throttling isn't there, right? > > Not entirely no. Timer alignment will still happen but when DoWork runs out of > things to do virtual time will fast forward to the next timer, whatever that > happens to be. Right, so essentially with virtual time there's no difference between a foreground and a background tab (except how things interleave). Show quoted text > > Just thinking about crbug.com/485425 in the context of this. > Pretty sure this isn't what they want there. Why not? It will make timer based tests execute quickly regardless of tab visibility. It could break timeout-based logic which may or may not be an issue.
	13 const char kEnableVirtualizedTime[] = "enable-virtualized-time";

	14

	15 } // namespace switches

	16 } // namespace scheduler

OLD	NEW