Small clean up of GDataWapiUrlGenerator.

Small clean up of GDataWapiUrlGenerator.

Removed unnecessary query parameter "include-installed-apps=true" from
AddFeedUrlParams. Use base::IntToString instead of StringPrintf for trivial
case.
This is a preparation to add new method into GDataWapiUrlGenerator to support
"search by title exact match".

BUG=232352
TEST=Ran unit_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195191

[hidehiko, 2013-04-18 09:20:29]

Thank you for your review in advance,
- hidehiko

[kinaba, 2013-04-18 09:47:45]

lgtm, but with a question just came to my mind.

https://codereview.chromium.org/14240004/diff/1/chrome/browser/google_apis/gd...
File chrome/browser/google_apis/gdata_wapi_url_generator.cc (right):

https://codereview.chromium.org/14240004/diff/1/chrome/browser/google_apis/gd...
chrome/browser/google_apis/gdata_wapi_url_generator.cc:88: result,
"start-index", base::IntToString(changestamp));
This is not directly related to this patch, but I'm just wondering,
why is |changestamp| int here? Almost everywhere else in the
code we are using int64 for changestamps.

[hidehiko, 2013-04-18 09:59:05]

On 2013/04/18 09:47:45, kinaba wrote:
> lgtm, but with a question just came to my mind.
> 
>
https://codereview.chromium.org/14240004/diff/1/chrome/browser/google_apis/gd...
> File chrome/browser/google_apis/gdata_wapi_url_generator.cc (right):
> 
>
https://codereview.chromium.org/14240004/diff/1/chrome/browser/google_apis/gd...
> chrome/browser/google_apis/gdata_wapi_url_generator.cc:88: result,
> "start-index", base::IntToString(changestamp));
> This is not directly related to this patch, but I'm just wondering,
> why is |changestamp| int here? Almost everywhere else in the
> code we are using int64 for changestamps.

Looks like the spec gap between GData WAPI and Drive API v2?

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/goo...

[kinaba, 2013-04-18 10:57:45]

On 2013/04/18 09:59:05, hidehiko wrote:
> On 2013/04/18 09:47:45, kinaba wrote:
> > lgtm, but with a question just came to my mind.
> > 
> >
>
https://codereview.chromium.org/14240004/diff/1/chrome/browser/google_apis/gd...
> > File chrome/browser/google_apis/gdata_wapi_url_generator.cc (right):
> > 
> >
>
https://codereview.chromium.org/14240004/diff/1/chrome/browser/google_apis/gd...
> > chrome/browser/google_apis/gdata_wapi_url_generator.cc:88: result,
> > "start-index", base::IntToString(changestamp));
> > This is not directly related to this patch, but I'm just wondering,
> > why is |changestamp| int here? Almost everywhere else in the
> > code we are using int64 for changestamps.
> 
> Looks like the spec gap between GData WAPI and Drive API v2?
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/goo...

I couldn't find the formal definition in the document, but public clients for
GData API
https://code.google.com/p/gdata-java-client/source/browse/trunk/java/src/com/...
looks to be using 64-bit value for changestamp already.
We might want to follow it (though we're toward deprecating it, anyhow...)

[hidehiko, 2013-04-18 13:15:23]

On 2013/04/18 10:57:45, kinaba wrote:
> On 2013/04/18 09:59:05, hidehiko wrote:
> > On 2013/04/18 09:47:45, kinaba wrote:
> > > lgtm, but with a question just came to my mind.
> > > 
> > >
> >
>
https://codereview.chromium.org/14240004/diff/1/chrome/browser/google_apis/gd...
> > > File chrome/browser/google_apis/gdata_wapi_url_generator.cc (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/14240004/diff/1/chrome/browser/google_apis/gd...
> > > chrome/browser/google_apis/gdata_wapi_url_generator.cc:88: result,
> > > "start-index", base::IntToString(changestamp));
> > > This is not directly related to this patch, but I'm just wondering,
> > > why is |changestamp| int here? Almost everywhere else in the
> > > code we are using int64 for changestamps.
> > 
> > Looks like the spec gap between GData WAPI and Drive API v2?
> > 
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/goo...
> 
> I couldn't find the formal definition in the document, but public clients for
> GData API
>
https://code.google.com/p/gdata-java-client/source/browse/trunk/java/src/com/...
> looks to be using 64-bit value for changestamp already.
> We might want to follow it (though we're toward deprecating it, anyhow...)

I see. So, I replaced with int64 as the diff looks small enough. Could you take
another look?

[kinaba, 2013-04-18 13:17:25]

lgtm. thanks!!11

[hashimoto, 2013-04-19 03:17:58]

lgtm

[commit-bot: I haz the power, 2013-04-19 03:20:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hidehiko@chromium.org/14240004/6001

[commit-bot: I haz the power, 2013-04-19 14:46:47]

Change committed as 195191