Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1423973006: PPC: Remove CallFunctionStub, always call through the Call builtin (also from CallIC). (Closed)

Created:
5 years, 1 month ago by MTBrandyberry
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Remove CallFunctionStub, always call through the Call builtin (also from CallIC). Port 44c44521ae11859478b42004f57ea93df52526ee Original commit message: This fixes receiver conversion since the Call builtin does it correctly. R=verwaest@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG=v8:4526 LOG=n Committed: https://crrev.com/44fcc2e7950fdaf4fb3d36c61370a6011bb654ea Cr-Commit-Position: refs/heads/master@{#31901}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -178 lines) Patch
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 9 chunks +13 lines, -16 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 5 chunks +8 lines, -155 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (3 generated)
MTBrandyberry
5 years, 1 month ago (2015-11-09 20:20:10 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423973006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423973006/1
5 years, 1 month ago (2015-11-09 20:25:19 UTC) #3
michael_dawson
On 2015/11/09 20:25:19, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
5 years, 1 month ago (2015-11-09 20:43:35 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-09 20:44:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423973006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423973006/1
5 years, 1 month ago (2015-11-09 20:46:21 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-09 20:47:49 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 20:48:42 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44fcc2e7950fdaf4fb3d36c61370a6011bb654ea
Cr-Commit-Position: refs/heads/master@{#31901}

Powered by Google App Engine
This is Rietveld 408576698