Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1423973002: [Chromecast] Change UMA_HISTOGRAM_CUSTOM_COUNTS_NO_CACHE to use AddCount. (Closed)

Created:
5 years, 1 month ago by bcf
Modified:
5 years, 1 month ago
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, asvitkine+watch_chromium.org, halliwell+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Change UMA_HISTOGRAM_CUSTOM_COUNTS_NO_CACHE to use AddCount. This removes uncessary increment loops. BUG=internal b/23563097 Committed: https://crrev.com/5ae45b51a10b19a9f8066cad21e0c7e075fa4c4d Cr-Commit-Position: refs/heads/master@{#360992}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chromecast/base/metrics/cast_histograms.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chromecast/browser/metrics/external_metrics.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
bcf
5 years, 1 month ago (2015-10-27 00:15:46 UTC) #3
gfhuang
lgtm
5 years, 1 month ago (2015-10-27 01:12:54 UTC) #4
Ian Coolidge
lgtm
5 years, 1 month ago (2015-10-27 01:28:56 UTC) #5
halliwell
On 2015/10/27 01:28:56, Ian Coolidge wrote: > lgtm rs-lgtm
5 years, 1 month ago (2015-10-27 02:57:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423973002/1
5 years, 1 month ago (2015-11-21 01:21:45 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-21 02:51:18 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-21 02:52:02 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ae45b51a10b19a9f8066cad21e0c7e075fa4c4d
Cr-Commit-Position: refs/heads/master@{#360992}

Powered by Google App Engine
This is Rietveld 408576698