Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1423953004: Android framework builds can't see cpu-features.h (Closed)

Created:
5 years, 1 month ago by mtklein_C
Modified:
5 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Android framework builds can't see cpu-features.h Don't try to do NEON detection for Android framework builds. BUG=skia: Committed: https://skia.googlesource.com/skia/+/7de63d50d4cda278c67d8ddb0d07a8ca6a56c74a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M src/core/SkOpts.cpp View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
mtklein_C
5 years, 1 month ago (2015-10-28 20:30:40 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423953004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423953004/1
5 years, 1 month ago (2015-10-28 20:30:53 UTC) #4
tomhudson
Derek says we don't have trybot support for Android, so we just cross our fingers ...
5 years, 1 month ago (2015-10-28 20:40:08 UTC) #6
tomhudson
lgtm
5 years, 1 month ago (2015-10-28 20:40:18 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-28 20:42:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423953004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423953004/1
5 years, 1 month ago (2015-10-28 20:45:13 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 20:46:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7de63d50d4cda278c67d8ddb0d07a8ca6a56c74a

Powered by Google App Engine
This is Rietveld 408576698