Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1423923003: Removed the dependency of the test RunComputedCodeObject from RawMachineAssemblerTester. (Closed)

Created:
5 years, 1 month ago by ahaas
Modified:
5 years, 1 month ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Removed the dependency of the test RunComputedCodeObject from RawMachineAssemblerTester. R=titzer@chromium.org Committed: https://crrev.com/0abac748cd8130d29c7d92c16303cbe1d12745d5 Cr-Commit-Position: refs/heads/master@{#31586}

Patch Set 1 #

Total comments: 4

Patch Set 2 : GraphBuilderTester is used now instead of copying the code from RawMachineAssemblerTester #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M test/cctest/compiler/graph-builder-tester.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 4 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
ahaas
5 years, 1 month ago (2015-10-26 21:46:20 UTC) #1
titzer
https://codereview.chromium.org/1423923003/diff/1/test/cctest/compiler/test-run-machops.cc File test/cctest/compiler/test-run-machops.cc (right): https://codereview.chromium.org/1423923003/diff/1/test/cctest/compiler/test-run-machops.cc#newcode5510 test/cctest/compiler/test-run-machops.cc:5510: Handle<Code> GenerateCode(RawMachineAssembler* r) { You shouldn't need to duplicate ...
5 years, 1 month ago (2015-10-26 21:58:30 UTC) #2
ahaas
https://codereview.chromium.org/1423923003/diff/1/test/cctest/compiler/test-run-machops.cc File test/cctest/compiler/test-run-machops.cc (right): https://codereview.chromium.org/1423923003/diff/1/test/cctest/compiler/test-run-machops.cc#newcode5510 test/cctest/compiler/test-run-machops.cc:5510: Handle<Code> GenerateCode(RawMachineAssembler* r) { On 2015/10/26 21:58:30, titzer wrote: ...
5 years, 1 month ago (2015-10-27 00:13:39 UTC) #3
titzer
lgtm
5 years, 1 month ago (2015-10-27 00:14:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423923003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423923003/20001
5 years, 1 month ago (2015-10-27 00:15:12 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-27 00:37:32 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 00:38:16 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0abac748cd8130d29c7d92c16303cbe1d12745d5
Cr-Commit-Position: refs/heads/master@{#31586}

Powered by Google App Engine
This is Rietveld 408576698