A crasher due to lacking 'template' node in XFA file

A crasher due to lacking 'template' node in XFA file

A template node is mandatory in XFA file. Pdfium should
ignore processing it when no template node is found in
XFA file.

BUG=pdfium:216
R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/bf18cb6220aa19a64d2705640aad29d3f86ed04a

[jun_fang, 2015-10-26 11:05:29]

Description was changed from

==========
A crashier due to lacking 'template' note in XFA file

BUG=Issue 216
==========

to

==========
A crashier due to lacking 'template' node in XFA file

A template node is mandatory in xfa file. Pdfium should
ignore processing it when no template node is found in 
xfa file.

BUG=Issue 216
==========

[jun_fang, 2015-10-26 13:34:33]

jun_fang@foxitsoftware.com changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[jun_fang, 2015-10-26 13:34:34]

Hi Tom and Lei,

Please help to review this CL. Thanks!

[Tom Sepez, 2015-10-26 16:04:32]

lgtm

https://codereview.chromium.org/1423903002/diff/60001/xfa/src/fxfa/src/parser...
File xfa/src/fxfa/src/parser/xfa_parser_imp.cpp (right):

https://codereview.chromium.org/1423903002/diff/60001/xfa/src/fxfa/src/parser...
xfa/src/fxfa/src/parser/xfa_parser_imp.cpp:436: IFDE_XMLNode*
pXMLTemplateDOMRoot = NULL;
nit: nullptr for new code, fix above two and a couple below.

https://codereview.chromium.org/1423903002/diff/60001/xfa/src/fxfa/src/parser...
xfa/src/fxfa/src/parser/xfa_parser_imp.cpp:479: // Find a duplicate template
packet
nit: s/Find/Found/, also . at end.

[Lei Zhang, 2015-10-26 17:49:43]

Description was changed from

==========
A crashier due to lacking 'template' node in XFA file

A template node is mandatory in xfa file. Pdfium should
ignore processing it when no template node is found in 
xfa file.

BUG=Issue 216
==========

to

==========
A crasher due to lacking 'template' node in XFA file

A template node is mandatory in XFA file. Pdfium should
ignore processing it when no template node is found in 
XFA file.

BUG=pdfium:216
==========

[Lei Zhang, 2015-10-26 17:50:53]

I made some minor edits to the CL description.

[jun_fang, 2015-10-27 04:01:40]

https://codereview.chromium.org/1423903002/diff/60001/xfa/src/fxfa/src/parser...
File xfa/src/fxfa/src/parser/xfa_parser_imp.cpp (right):

https://codereview.chromium.org/1423903002/diff/60001/xfa/src/fxfa/src/parser...
xfa/src/fxfa/src/parser/xfa_parser_imp.cpp:436: IFDE_XMLNode*
pXMLTemplateDOMRoot = NULL;
On 2015/10/26 16:04:32, Tom Sepez wrote:
> nit: nullptr for new code, fix above two and a couple below.

Acknowledged.

https://codereview.chromium.org/1423903002/diff/60001/xfa/src/fxfa/src/parser...
xfa/src/fxfa/src/parser/xfa_parser_imp.cpp:479: // Find a duplicate template
packet
On 2015/10/26 16:04:32, Tom Sepez wrote:
> nit: s/Find/Found/, also . at end.

Acknowledged.

[jun_fang, 2015-10-27 04:24:37]

+Bin

[jun_fang, 2015-10-28 10:36:58]

Committed patchset #7 (id:120001) manually as
bf18cb6220aa19a64d2705640aad29d3f86ed04a (presubmit successful).