Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 1423883002: content: Fix for GN Mac build. (Closed)

Created:
5 years, 1 month ago by tfarina
Modified:
5 years, 1 month ago
Reviewers:
brettw
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, darin-cc_chromium.org, Avi (use Gerrit), Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Fix for GN Mac build. Fix the following error: ninja: error: '../../content/shell/shell_content_main.cc', needed by 'obj/content/shell/libcontent_shell_framework/shell_content_main.o', missing and no known rule to make it Tested on Mac with the following command lines: $ gn gen out-gn/Release --args='is_debug=false is_component_build=false symbol_level=1' $ ninja -C out-gn/Release The fix is simple as shell_content_main.cc lives in content/shell/app rather than content/shell. BUG=431177 TBR=brettw@chromium.org Committed: https://crrev.com/c708f3974380273cd9a2c8882715706a0b9e56c1 Cr-Commit-Position: refs/heads/master@{#355993}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/shell/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
tfarina
TBRing...
5 years, 1 month ago (2015-10-25 17:09:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423883002/1
5 years, 1 month ago (2015-10-25 17:09:49 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-25 17:42:59 UTC) #4
commit-bot: I haz the power
5 years, 1 month ago (2015-10-25 17:43:52 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c708f3974380273cd9a2c8882715706a0b9e56c1
Cr-Commit-Position: refs/heads/master@{#355993}

Powered by Google App Engine
This is Rietveld 408576698