Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 1423843004: Reland of Update catapult recipe to run py-vulcanize (tvcm) tests. (Closed)

Created:
5 years, 1 month ago by qyearsley
Modified:
5 years, 1 month ago
Reviewers:
sullivan
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Reland of Update catapult recipe to run py-vulcanize (tvcm) tests. (patchset #1 id:1 of https://codereview.chromium.org/1400913002/ ) Reason for revert: The original CL should be able to be re-landed if https://codereview.chromium.org/1422623008/ has been committed to catapult first. Original issue's description: > Revert of Update catapult recipe to run py-vulcanize (tvcm) tests. (patchset #1 id:1 of https://codereview.chromium.org/1377973007/ ) > > Reason for revert: > Causes failures on catapult waterfall and tryserver: > https://build.chromium.org/p/tryserver.client.catapult/builders > https://build.chromium.org/p/client.catapult/builders > > Original issue's description: > > Update catapult recipe to run py-vulcanize (tvcm) tests. > > > > https://github.com/catapult-project/catapult/issues/1584 > > > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297072 > > TBR=sullivan@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297080 TBR=sullivan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297407

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M scripts/slave/recipes/catapult.py View 2 chunks +6 lines, -1 line 0 comments Download
M scripts/slave/recipes/catapult.expected/basic.json View 2 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
qyearsley
Created Reland of Update catapult recipe to run py-vulcanize (tvcm) tests.
5 years, 1 month ago (2015-10-27 16:58:32 UTC) #1
qyearsley
This should only be re-landed after https://codereview.chromium.org/1422623008/. Does it seem OK?
5 years, 1 month ago (2015-10-27 17:00:05 UTC) #2
qyearsley
On 2015/10/27 17:00:05, qyearsley wrote: > This should only be re-landed after https://codereview.chromium.org/1422623008/. > > ...
5 years, 1 month ago (2015-10-30 16:27:57 UTC) #3
sullivan
lgtm
5 years, 1 month ago (2015-10-30 16:57:00 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423843004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423843004/1
5 years, 1 month ago (2015-10-30 17:08:43 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-30 17:08:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423843004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423843004/1
5 years, 1 month ago (2015-10-30 17:09:44 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 17:09:52 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297407

Powered by Google App Engine
This is Rietveld 408576698