Make version.dart ready for svn 1.7 checkouts

tools/release/version.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * This file contains functionality for getting dart version numbers using
  * our standard version construction method. Systems that does not include this
  * file should emulate the structure for revision numbers that we have here.
  *
  * The version number of a dart build is constructed as follows:
@@ skipping 171 matching lines @@
       key = "USERNAME";
     }
     if (!Platform.environment.containsKey(key)) return "";
     var username = Platform.environment[key];
     // If this is a production build, i.e., this is something we are shipping,
     // don't suffix  the version with the username.
     if (isProductionBuild(username)) return "";
     return username;
   }
 
-  bool isGitRepository() {
+  RepositoryType get repositoryType {
+    bool hasDirectory(path, name) {
+      return new Directory.fromPath(path.append(name)).existsSync();
+    }
+
     var currentPath = new Path(new Directory.current().path);

[Bill Hesse, 2013/04/29 11:58:56]

This is changing to Directory.current, so if version runs against the checked-in
binary, this will need to change when new ones are checked in.

[kustermann, 2013/04/30 09:38:44]

Thanks for the hint.

-    while (!new Directory.fromPath(currentPath.append(".git")).existsSync()) {
-      currentPath = currentPath.directoryPath;
+    while (true) {
+      if (hasDirectory(currentPath, '.svn')) {
+        return RepositoryType.SVN;
+      } else if (hasDirectory(currentPath, '.git')) {
+        return RepositoryType.GIT;
+      }
       if (currentPath.toString() == "/") {

[Bill Hesse, 2013/04/29 11:58:56]

I'm not sure this will work on Windows - paths will start /C:/, and I guess
directoryPath will strip this down to /.  But there are also network shares:
//myshare/path/parts.

I don't have a really good solution for this, except path.append('..') might be
more likely to do the right thing.  But probably not.

Perhaps we could break one step earlier by putting currentPath =
currentPath.directoryPath before this test.  I think that would be slightly
safer, because we don't check '/'.

Also, I guess currentPath can't include .., but if it did, then using
.directoryPath would do the wrong thing, and go down a level, instead of up.

[ricow1, 2013/04/30 07:21:28]

I think we can fix this by doing:
do {


} while (currentPath != currentPath.directoryPath)

[kustermann, 2013/04/30 09:38:44]

I think this is not doing what we want. It allows you to go through the loop
once if you invoke it with cwd '/' but not with cwd '/tmp'.

I changed it now to stop as soon as the root of the filesystem was scanned. (No
sane person has a checkout on '/' or 'C:\', but it's cleaner this way)

         break;
       }
+      currentPath = currentPath.directoryPath;
     }
-    return new Directory.fromPath(currentPath.append(".git")).existsSync();
-  }
-
-  RepositoryType get repositoryType {
-    if (new Directory(".svn").existsSync()) return RepositoryType.SVN;
-    if (isGitRepository()) return RepositoryType.GIT;
     return RepositoryType.UNKNOWN;
   }
 }
 
 class RepositoryType {
   static final RepositoryType SVN = const RepositoryType("SVN");
   static final RepositoryType GIT = const RepositoryType("GIT");
   static final RepositoryType UNKNOWN = const RepositoryType("UNKNOWN");
 
   const RepositoryType(String this.name);
 
   static RepositoryType guessType() {
     if (new Directory(".svn").existsSync()) return RepositoryType.SVN;
     if (new Directory(".git").existsSync()) return RepositoryType.GIT;
     return RepositoryType.UNKNOWN;
   }
 
   String toString() => name;
 
   final String name;
 }