Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Side by Side Diff: chrome/common/extensions/extension.h

Issue 14238037: Made it possible to tell whether an extension is being installed or updated. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Test that already_installed is true on update, false on install. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_H_ 5 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_H_
6 #define CHROME_COMMON_EXTENSIONS_EXTENSION_H_ 6 #define CHROME_COMMON_EXTENSIONS_EXTENSION_H_
7 7
8 #include <algorithm> 8 #include <algorithm>
9 #include <iosfwd> 9 #include <iosfwd>
10 #include <map> 10 #include <map>
(...skipping 679 matching lines...) Expand 10 before | Expand all | Expand 10 after
690 690
691 scoped_ptr<base::DictionaryValue> extension_manifest; 691 scoped_ptr<base::DictionaryValue> extension_manifest;
692 std::string extension_id; 692 std::string extension_id;
693 base::FilePath extension_path; 693 base::FilePath extension_path;
694 Manifest::Location extension_location; 694 Manifest::Location extension_location;
695 695
696 private: 696 private:
697 DISALLOW_COPY_AND_ASSIGN(ExtensionInfo); 697 DISALLOW_COPY_AND_ASSIGN(ExtensionInfo);
698 }; 698 };
699 699
700 struct InstalledExtensionInfo {
701 // The extension being installed - this should always be non-NULL.
702 const Extension* extension;
703
704 // Was the extension already installed? (If true, this means the extension is
705 // being updated.)
706 bool already_installed;
benwells 2013/05/02 01:40:08 I think this is more clear if it is just called is
Matt Giuca 2013/05/02 05:40:33 Done.
707
708 InstalledExtensionInfo(const Extension* extension, bool already_installed);
709 };
710
700 struct UnloadedExtensionInfo { 711 struct UnloadedExtensionInfo {
701 extension_misc::UnloadedExtensionReason reason; 712 extension_misc::UnloadedExtensionReason reason;
702 713
703 // Was the extension already disabled? 714 // Was the extension already disabled?
704 bool already_disabled; 715 bool already_disabled;
705 716
706 // The extension being unloaded - this should always be non-NULL. 717 // The extension being unloaded - this should always be non-NULL.
707 const Extension* extension; 718 const Extension* extension;
708 719
709 UnloadedExtensionInfo( 720 UnloadedExtensionInfo(
(...skipping 20 matching lines...) Expand all
730 741
731 UpdatedExtensionPermissionsInfo( 742 UpdatedExtensionPermissionsInfo(
732 const Extension* extension, 743 const Extension* extension,
733 const PermissionSet* permissions, 744 const PermissionSet* permissions,
734 Reason reason); 745 Reason reason);
735 }; 746 };
736 747
737 } // namespace extensions 748 } // namespace extensions
738 749
739 #endif // CHROME_COMMON_EXTENSIONS_EXTENSION_H_ 750 #endif // CHROME_COMMON_EXTENSIONS_EXTENSION_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698