Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Issue 1423803003: Explicitly defines the kClockSystemTrace in the syscall parameters test (Closed)

Created:
5 years, 1 month ago by charliea (OOO until 10-5)
Modified:
5 years, 1 month ago
CC:
chromium-reviews, jln+watch_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly defines the kClockSystemTrace in the syscall parameters test TraceTicks is going away, so TraceTicks::kClockSystemTrace is also going away. If this test is to continue existing, it needs to define the clock ID itself. BUG=541692 Committed: https://crrev.com/bdcd6db1893a596f9454ae22e33f35541b6f240d Cr-Commit-Position: refs/heads/master@{#357871}

Patch Set 1 : #

Patch Set 2 : Removes test altogether #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions_unittests.cc View 1 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
charliea (OOO until 10-5)
5 years, 1 month ago (2015-11-04 13:40:31 UTC) #2
charliea (OOO until 10-5)
On 2015/11/04 13:40:31, charliea wrote: Hi Ricky, If you'd prefer that I just kill this ...
5 years, 1 month ago (2015-11-04 13:41:38 UTC) #3
rickyz (no longer on Chrome)
Like I mentioned in chat, I'd probably lean towards just removing the fest altogether - ...
5 years, 1 month ago (2015-11-04 19:06:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423803003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423803003/40001
5 years, 1 month ago (2015-11-04 19:07:26 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 1 month ago (2015-11-04 19:25:26 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 19:26:20 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bdcd6db1893a596f9454ae22e33f35541b6f240d
Cr-Commit-Position: refs/heads/master@{#357871}

Powered by Google App Engine
This is Rietveld 408576698