Issue 14238014: Fix erroneous log message in mork_reader.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14238014: Fix erroneous log message in mork_reader.cc. (Closed)

Created:
7 years, 8 months ago by gab

Modified:
7 years, 8 months ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix erroneous log message in mork_reader.cc. Resulted in a warning message on properly formatted input as the key IS expected to be empty when the map ends (not the other way around)... Typical file being read by this code: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/data/firefox2_profile/history.dat&q=history.dat&sq=package:chromium&type=cs BUG=219419 Committed: http://crrev.com/194399

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/importer/mork_reader.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

gab

Miranda, please take a look at this one character CL :)! Cheers! Gab

7 years, 8 months ago (2013-04-16 17:09:41 UTC) #1

Miranda Callahan

On 2013/04/16 17:09:41, gab wrote: > Miranda, please take a look at this one character ...

7 years, 8 months ago (2013-04-16 17:37:14 UTC) #2

gab

7 years, 8 months ago (2013-04-16 19:00:14 UTC) #3

Message was sent while issue was closed.

Committed in r194399 (had to ctrl-C dcommit, but somehow the commit had already
gone in although it hadn't closed this CL).