Set up NaClChromeMainArgs number_of_cores member so apps can size threadpools appropriately

chrome/test/nacl/nacl_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include <stdio.h>
+#if defined(OS_POSIX)
+#include <unistd.h>
+#elif defined(OS_WIN)
+#include <windows.h>
+#endif
+
 #include "chrome/test/nacl/nacl_browsertest_util.h"
 
 namespace {
 
 // These tests fail on Linux ASAN bots: <http://crbug.com/161709>.
 #if defined(OS_LINUX) && defined(ADDRESS_SANITIZER)
 #define MAYBE_SimpleLoad DISABLED_SimpleLoad
 #define MAYBE_ExitStatus0 DISABLED_ExitStatus0
 #define MAYBE_ExitStatus254 DISABLED_ExitStatus254
 #define MAYBE_ExitStatusNeg2 DISABLED_ExitStatusNeg2
@@ skipping 36 matching lines @@
 })
 
 NACL_BROWSER_TEST_F(NaClBrowserTest, MAYBE_PPAPICore, {
   RunNaClIntegrationTest(FILE_PATH_LITERAL("ppapi_ppb_core.html"));
 })
 
 NACL_BROWSER_TEST_F(NaClBrowserTest, MAYBE_ProgressEvents, {
   RunNaClIntegrationTest(FILE_PATH_LITERAL("ppapi_progress_events.html"));
 })
 
+// Visual Studio does not like preprocessor conditionals inside the
+// argument of a macro, so we put the conditionals on a helper
+// function.  We are already in an anonymous namespace, so the name of
+// the helper is not visible in external scope.
+//
+// The string buffer is sufficient sized: 2**64 < 8**22 < 10**22.
+#if defined(OS_POSIX)
+base::FilePath::StringType NumberOfCoresAsFilePathString() {
+  char string_rep[23];
+  snprintf(string_rep, sizeof string_rep, "%ld", sysconf(_SC_NPROCESSORS_ONLN));
+  return string_rep;
+}
+#elif defined(OS_WIN)
+base::FilePath::StringType NumberOfCoresAsFilePathString() {
+  wchar_t string_rep[23];
+  SYSTEM_INFO system_info;
+  GetSystemInfo(&system_info);
+  _snwprintf_s(string_rep, sizeof string_rep, _TRUNCATE, L"%u",
+               system_info.dwNumberOfProcessors);
+  return string_rep;
+}
+#endif
+
+NACL_BROWSER_TEST_F(NaClBrowserTest, SysconfNprocessorsOnln, {

[jvoung (off chromium), 2013/04/17 17:07:18]

You might not need to "MAYBE_${testname}", but I can't guarantee it ;-)  The
other tests had "MAYBE" to disable it under Linux ASAN, but it might actually
work under asan nowadays.

[bsy, 2013/04/17 20:55:21]

Done.

+    base::FilePath::StringType path =
+        FILE_PATH_LITERAL("sysconf_nprocessors_onln_test.html?cpu_count=");
+    path = path + NumberOfCoresAsFilePathString();
+    RunNaClIntegrationTest(path);
+})
+
 IN_PROC_BROWSER_TEST_F(NaClBrowserTestStatic, MAYBE_CrossOriginCORS) {
   RunLoadTest(FILE_PATH_LITERAL("cross_origin/cors.html"));
 }
 
 IN_PROC_BROWSER_TEST_F(NaClBrowserTestStatic, MAYBE_CrossOriginFail) {
   RunLoadTest(FILE_PATH_LITERAL("cross_origin/fail.html"));
 }
 
 IN_PROC_BROWSER_TEST_F(NaClBrowserTestStatic, MAYBE_SameOriginCookie) {
   RunLoadTest(FILE_PATH_LITERAL("cross_origin/same_origin_cookie.html"));
@@ skipping 17 matching lines @@
                        MAYBE_PNACL(PnaclNMFOptionsOlarge)) {
   RunLoadTest(FILE_PATH_LITERAL("pnacl_options.html?use_nmf=o_large"));
 }
 
 IN_PROC_BROWSER_TEST_F(NaClBrowserTestPnacl,
                        MAYBE_PNACL(PnaclNMFOptionsTimePasses)) {
   RunLoadTest(FILE_PATH_LITERAL("pnacl_options.html?use_nmf=time_passes"));
 }
 
 }  // namespace anonymous