Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 14238007: Unify Sampler implementation across platforms using signals to suspend thread (Closed)

Created:
7 years, 8 months ago by yurys
Modified:
7 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

pthreads seem to be fully supported on Linux and Android which allows to remove many #ifdefs. Also OS::Sleep(interval_) is used to pause sampling thread on all platforms. It makes no sense to send signal once 900mks to compensate 100mks delay on signal delivery as the signals would be delivered once 900mks. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=14278

Patch Set 1 #

Patch Set 2 : Inlined variable #

Patch Set 3 : Removed empty line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -62 lines) Patch
M src/cpu-profiler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/log.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/platform.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/sampler.cc View 1 2 6 chunks +6 lines, -61 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yurys
7 years, 8 months ago (2013-04-16 10:53:10 UTC) #1
yurys
7 years, 8 months ago (2013-04-16 10:55:53 UTC) #2
Sven Panne
LGTM. At least if the sampler still works on Android... ;-) More seriously: I am ...
7 years, 8 months ago (2013-04-16 11:28:59 UTC) #3
yurys
On 2013/04/16 11:28:59, Sven Panne wrote: > LGTM. At least if the sampler still works ...
7 years, 8 months ago (2013-04-16 12:02:51 UTC) #4
yurys
7 years, 8 months ago (2013-04-16 12:06:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r14278 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698