Optimize plane usage when primary is obscured by Overlay

ui/ozone/platform/drm/gpu/hardware_display_plane_manager_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <drm_fourcc.h>
 
 #include <vector>
 
 #include "base/memory/scoped_ptr.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 13 matching lines @@
   uint32_t allowed_crtc_mask;
 };
 
 const FakePlaneInfo kOnePlanePerCrtc[] = {{10, 1}, {20, 2}};
 const FakePlaneInfo kTwoPlanesPerCrtc[] = {{10, 1}, {11, 1}, {20, 2}, {21, 2}};
 const FakePlaneInfo kOnePlanePerCrtcWithShared[] = {{10, 1}, {20, 2}, {50, 3}};
 const uint32_t kDummyFormat = 0;
 
 class FakeScanoutBuffer : public ui::ScanoutBuffer {
  public:
-  FakeScanoutBuffer(uint32_t format) : format_(format) {}
+  FakeScanoutBuffer(uint32_t format)
+      : format_(format), size_(gfx::Size(2, 2)) {}
 
   // ui::ScanoutBuffer:
   uint32_t GetFramebufferId() const override { return 1; }
   uint32_t GetHandle() const override { return 0; }
-  gfx::Size GetSize() const override { return gfx::Size(1, 1); }
+  void SetSize(const gfx::Size& size) { size_ = size; }
+  gfx::Size GetSize() const override { return size_; }
   void SetFramebufferPixelFormat(uint32_t format) { format_ = format; }
   uint32_t GetFramebufferPixelFormat() const override { return format_; }
   bool RequiresGlFinish() const override { return false; }
 
  protected:
   ~FakeScanoutBuffer() override {}
   uint32_t format_;
+  gfx::Size size_;
 };
 
 class FakePlaneManager : public ui::HardwareDisplayPlaneManager {
  public:
   FakePlaneManager() : plane_count_(0) {}
   ~FakePlaneManager() override {}
 
   // Normally we'd use DRM to figure out the controller configuration. But we
   // can't use DRM in unit tests, so we just create a fake configuration.
   void InitForTest(const FakePlaneInfo* planes,
@@ skipping 163 matching lines @@
   EXPECT_EQ(1, plane_manager_->plane_count());
   // The other plane should be used.
   EXPECT_TRUE(plane_manager_->AssignOverlayPlanes(&state_, assigns,
                                                   default_crtcs_[0], nullptr));
   EXPECT_EQ(2, plane_manager_->plane_count());
   EXPECT_NE(state_.plane_list[0], state_.plane_list[1]);
 }
 
 TEST_F(HardwareDisplayPlaneManagerTest, SharedPlanes) {
   ui::OverlayPlaneList assigns;
+  scoped_refptr<FakeScanoutBuffer> buffer =
+      new FakeScanoutBuffer(DRM_FORMAT_XRGB8888);
+  buffer->SetSize(gfx::Size(1, 1));
+
   assigns.push_back(ui::OverlayPlane(fake_buffer_));
-  assigns.push_back(ui::OverlayPlane(fake_buffer_));
+  assigns.push_back(ui::OverlayPlane(buffer));
   plane_manager_->InitForTest(kOnePlanePerCrtcWithShared,
                               arraysize(kOnePlanePerCrtcWithShared),
                               default_crtcs_);
 
   EXPECT_TRUE(plane_manager_->AssignOverlayPlanes(&state_, assigns,
                                                   default_crtcs_[1], nullptr));
   EXPECT_EQ(2, plane_manager_->plane_count());
   // The shared plane is now unavailable for use by the other CRTC.
   EXPECT_FALSE(plane_manager_->AssignOverlayPlanes(&state_, assigns,
                                                    default_crtcs_[0], nullptr));
@@ skipping 18 matching lines @@
   plane_manager_->BeginFrame(&state_);
   EXPECT_FALSE(plane_manager_->AssignOverlayPlanes(&state_, assigns,
                                                    default_crtcs_[0], nullptr));
 }
 
 TEST(HardwareDisplayPlaneManagerLegacyTest, UnusedPlanesAreReleased) {
   std::vector<uint32_t> crtcs;
   crtcs.push_back(100);
   scoped_refptr<ui::MockDrmDevice> drm = new ui::MockDrmDevice(false, crtcs, 2);
   ui::OverlayPlaneList assigns;
-  scoped_refptr<FakeScanoutBuffer> fake_buffer =
+  scoped_refptr<FakeScanoutBuffer> primary_buffer =
       new FakeScanoutBuffer(DRM_FORMAT_XRGB8888);
-  assigns.push_back(ui::OverlayPlane(fake_buffer));
-  assigns.push_back(ui::OverlayPlane(fake_buffer));
+  scoped_refptr<FakeScanoutBuffer> overlay_buffer =
+      new FakeScanoutBuffer(DRM_FORMAT_XRGB8888);
+  overlay_buffer->SetSize(gfx::Size(1, 1));
+  assigns.push_back(ui::OverlayPlane(primary_buffer));
+  assigns.push_back(ui::OverlayPlane(overlay_buffer));
   ui::HardwareDisplayPlaneList hdpl;
   ui::CrtcController crtc(drm, crtcs[0], 0);
   drm->plane_manager()->BeginFrame(&hdpl);
   EXPECT_TRUE(drm->plane_manager()->AssignOverlayPlanes(&hdpl, assigns,
                                                         crtcs[0], &crtc));
   EXPECT_TRUE(drm->plane_manager()->Commit(&hdpl, false));
   assigns.clear();
-  assigns.push_back(ui::OverlayPlane(fake_buffer));
+  assigns.push_back(ui::OverlayPlane(primary_buffer));
   drm->plane_manager()->BeginFrame(&hdpl);
   EXPECT_TRUE(drm->plane_manager()->AssignOverlayPlanes(&hdpl, assigns,
                                                         crtcs[0], &crtc));
   EXPECT_EQ(0, drm->get_overlay_clear_call_count());
   EXPECT_TRUE(drm->plane_manager()->Commit(&hdpl, false));
   EXPECT_EQ(1, drm->get_overlay_clear_call_count());
 }
 
 }  // namespace