Run telemetry_perf_unittests via isolate on "Windows Tests" & "Mac tests" and trybot.

Run telemetry_perf_unittests via isolate on "Windows Tests" & "Mac tests" and trybot.

BUG=507796
Committed: https://crrev.com/78fe10dde5b14fa699a8195ba050efc9c5204958
Cr-Commit-Position: refs/heads/master@{#356573}

[nednguyen, 2015-10-28 03:52:51]

Description was changed from

==========
Isolate telemetry_perf_unittest for mac & win

BUG=
==========

to

==========
Run telemetry_perf_unittests via isolate on "Windows Tests" & "Mac tests" and
trybot.

BUG=507796
==========

[nednguyen, 2015-10-28 03:52:52]

nednguyen@google.com changed reviewers:
+ maruel@chromium.org, phajdan.jr@chromium.org

[nednguyen, 2015-10-28 03:53:02]

Patchset #1 (id:1) has been deleted

[nednguyen, 2015-10-28 03:53:07]

Patchset #1 (id:20001) has been deleted

[nednguyen, 2015-10-28 03:53:14]

Patchset #1 (id:40001) has been deleted

[nednguyen, 2015-10-28 03:53:21]

Patchset #1 (id:60001) has been deleted

[nednguyen, 2015-10-28 03:53:31]

Patchset #1 (id:80001) has been deleted

[Paweł Hajdan Jr., 2015-10-28 13:23:01]

LGTM

[M-A Ruel, 2015-10-28 16:02:17]

lgtm

https://codereview.chromium.org/1423733003/diff/100001/chrome/telemetry_perf_...
File chrome/telemetry_perf_unittests.isolate (right):

https://codereview.chromium.org/1423733003/diff/100001/chrome/telemetry_perf_...
chrome/telemetry_perf_unittests.isolate:9: ['OS=="mac" or OS=="win"', {
There's no perf test on linux of chromeos?

https://codereview.chromium.org/1423733003/diff/100001/chrome/telemetry_perf_...
chrome/telemetry_perf_unittests.isolate:21: '-v',
Is it planned to be permanent or temporary?

https://codereview.chromium.org/1423733003/diff/100001/tools/perf/perf.isolate
File tools/perf/perf.isolate (right):

https://codereview.chromium.org/1423733003/diff/100001/tools/perf/perf.isolat...
tools/perf/perf.isolate:9: ['OS=="android" or OS=="linux" or OS=="mac" or
OS=="win"', {
probably better to remove Android?

[nednguyen, 2015-10-28 16:11:42]

https://codereview.chromium.org/1423733003/diff/100001/chrome/telemetry_perf_...
File chrome/telemetry_perf_unittests.isolate (right):

https://codereview.chromium.org/1423733003/diff/100001/chrome/telemetry_perf_...
chrome/telemetry_perf_unittests.isolate:9: ['OS=="mac" or OS=="win"', {
On 2015/10/28 16:02:16, M-A Ruel wrote:
> There's no perf test on linux of chromeos?

The linux one is defined in BUILD.gn
here:https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/BUILD.gn&l=655

https://codereview.chromium.org/1423733003/diff/100001/chrome/telemetry_perf_...
chrome/telemetry_perf_unittests.isolate:21: '-v',
On 2015/10/28 16:02:16, M-A Ruel wrote:
> Is it planned to be permanent or temporary?

One mac & win can also use BUILD.gn, we can remove this.

https://codereview.chromium.org/1423733003/diff/100001/tools/perf/perf.isolate
File tools/perf/perf.isolate (right):

https://codereview.chromium.org/1423733003/diff/100001/tools/perf/perf.isolat...
tools/perf/perf.isolate:9: ['OS=="android" or OS=="linux" or OS=="mac" or
OS=="win"', {
On 2015/10/28 16:02:16, M-A Ruel wrote:
> probably better to remove Android?

I plan to switch telemetr_perf_unittests_android to use this:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/telemetry_p...

[nednguyen, 2015-10-28 16:11:46]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2015-10-28 16:12:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1423733003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1423733003/100001

[commit-bot: I haz the power, 2015-10-28 17:14:27]

Committed patchset #1 (id:100001)

[commit-bot: I haz the power, 2015-10-28 17:15:35]

Patchset 1 (id:??) landed as
https://crrev.com/78fe10dde5b14fa699a8195ba050efc9c5204958
Cr-Commit-Position: refs/heads/master@{#356573}

[Ken Russell (switch to Gerrit), 2015-10-28 18:06:32]

kbr@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2015-10-28 18:06:32]

This is excellent. LGTM after the fact.

[Georges Khalil, 2015-10-28 19:08:40]

A revert of this CL (patchset #1 id:100001) has been created in
https://codereview.chromium.org/1417923005/ by georgesak@chromium.org.

The reason for reverting is: This seems to break the Mac Builder. Output is
here:

https://build.chromium.org/p/chromium.mac/builders/Mac%20Builder/builds/30992.

[Ken Russell (switch to Gerrit), 2015-10-28 21:47:22]

https://codereview.chromium.org/1423733003/diff/100001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

https://codereview.chromium.org/1423733003/diff/100001/chrome/chrome_tests.gy...
chrome/chrome_tests.gypi:3209:
'../content/content_shell_and_tests.gyp:telemetry_base',
This needs to depend on telemetry_chrome_test_base in this same gypi file to
match the inclusion of telemetry_chrome_test.isolate in tools/perf/perf.isolate
-- I think.