Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 1423733002: X87: [Interpreter] Support for operator new. (Closed)

Created:
5 years, 2 months ago by zhengxing.li
Modified:
5 years, 2 months ago
Reviewers:
Weiliang, chunyang.dai
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [Interpreter] Support for operator new. port 7557dc5a70e333ba10eb370fe6e7b7a31760d891 (r31312). original commit message: This change add a new bytecode for operator new and implements it using the Construct() builtin. BUG= Committed: https://crrev.com/b5b590f511c01789d7c6cfc326e012456a365d9e Cr-Commit-Position: refs/heads/master@{#31518}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -10 lines) Patch
M src/x87/builtins-x87.cc View 4 chunks +61 lines, -10 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zhengxing.li
5 years, 2 months ago (2015-10-23 10:15:23 UTC) #2
Weiliang
lgtm
5 years, 2 months ago (2015-10-23 10:57:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423733002/1
5 years, 2 months ago (2015-10-23 10:57:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 12:20:37 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 12:21:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5b590f511c01789d7c6cfc326e012456a365d9e
Cr-Commit-Position: refs/heads/master@{#31518}

Powered by Google App Engine
This is Rietveld 408576698