Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1423723007: Revert of Enable multiprocess by default on desktop mojo_runner. (Closed)

Created:
5 years, 1 month ago by jam
Modified:
5 years, 1 month ago
Reviewers:
msw, sky
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, xhwang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable multiprocess by default on desktop mojo_runner. (patchset #7 id:120001 of https://codereview.chromium.org/1434563004/ ) Reason for revert: This is failing on CQ and waterfall now. It might have conflicted with another patch that landed in the meantime. Original issue's description: > Enable multiprocess by default on desktop mojo_runner. > > This makes apptests also run in multiprocess and use the new EDK as well. > > BUG=478251, 546644, 551083 > > Committed: https://crrev.com/14d2827bffed6b8c4928001eb42d9f4dda23dd81 > Cr-Commit-Position: refs/heads/master@{#358664} TBR=sky@chromium.org,msw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=478251, 546644, 551083 Committed: https://crrev.com/5a930985c25d09084206c33bebbb2b60e65f2fd8 Cr-Commit-Position: refs/heads/master@{#358703}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -22 lines) Patch
M mojo/message_pump/handle_watcher.cc View 1 chunk +1 line, -7 lines 0 comments Download
M mojo/runner/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M mojo/runner/desktop/launcher_process.cc View 1 chunk +5 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jam
Created Revert of Enable multiprocess by default on desktop mojo_runner.
5 years, 1 month ago (2015-11-09 23:27:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423723007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423723007/1
5 years, 1 month ago (2015-11-09 23:30:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423723007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423723007/1
5 years, 1 month ago (2015-11-09 23:35:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-09 23:37:17 UTC) #4
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 23:37:59 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a930985c25d09084206c33bebbb2b60e65f2fd8
Cr-Commit-Position: refs/heads/master@{#358703}

Powered by Google App Engine
This is Rietveld 408576698