Map v8::Function to JSReceiver + IsCallable

Map v8::Function to JSReceiver + IsCallable

BUG=none
LOG=y
R=verwaest@chromium.org,bmeurer@chromium.org,rossberg@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng

Committed: https://crrev.com/5587656155b1f7d6eff7894c39d89246cf84b94a
Cr-Commit-Position: refs/heads/master@{#31519}

[jochen (gone - plz use gerrit), 2015-10-23 09:26:32]

ptal

Toon, review everything

Benedikt/Andreas, fyi

esp. tests still assume that everything is functions... but hey, that's tests :)

[rossberg, 2015-10-23 10:45:45]

Looks good, although I really think we should have a JSCallable type to make
this clearer.

https://codereview.chromium.org/1423723002/diff/1/src/execution.h
File src/execution.h (right):

https://codereview.chromium.org/1423723002/diff/1/src/execution.h#newcode50
src/execution.h:50: static MaybeHandle<Object> TryCall(Isolate* isolate,
Handle<Object> func,
Nit: rename param to `callable`, like above.

[jochen (gone - plz use gerrit), 2015-10-23 10:46:39]

On 2015/10/23 at 10:45:45, rossberg wrote:
> Looks good, although I really think we should have a JSCallable type to make
this clearer.

Yeah, but not in the public API

> 
> https://codereview.chromium.org/1423723002/diff/1/src/execution.h
> File src/execution.h (right):
> 
> https://codereview.chromium.org/1423723002/diff/1/src/execution.h#newcode50
> src/execution.h:50: static MaybeHandle<Object> TryCall(Isolate* isolate,
Handle<Object> func,
> Nit: rename param to `callable`, like above.

[jochen (gone - plz use gerrit), 2015-10-23 10:54:17]

btw, once e.g. Function.bind() creates something that's not an JSFunction,
Function::GetBoundFunction needs to be updated to not check for IsJSFunction(),
etc..

[Toon Verwaest, 2015-10-23 11:06:34]

lgtm with 2 nits

https://codereview.chromium.org/1423723002/diff/1/src/debug/debug.cc
File src/debug/debug.cc (right):

https://codereview.chromium.org/1423723002/diff/1/src/debug/debug.cc#newcode2422
src/debug/debug.cc:2422: isolate, Handle<JSFunction>::cast(fun), event_data_, 0,
NULL);
you don't need this cast anymore I guess

https://codereview.chromium.org/1423723002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1423723002/diff/1/src/objects.cc#newcode11986
src/objects.cc:11986: Handle<JSFunction> method =
Handle<JSFunction>::cast(property);
I think you don't need this cast anymore.

[Benedikt Meurer, 2015-10-23 11:12:56]

I agree with Andreas we should have an internal JSCallable (soonish). Otherwise
LGTM from my side.

[jochen (gone - plz use gerrit), 2015-10-23 11:15:47]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2015-10-23 11:15:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1423723002/#ps40001
(title: "updates")

[commit-bot: I haz the power, 2015-10-23 11:15:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1423723002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1423723002/40001

[jochen (gone - plz use gerrit), 2015-10-23 11:27:55]

The CQ bit was unchecked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2015-10-23 11:29:46]

Description was changed from

==========
Map v8::Function to JSReceiver + IsCallable

BUG=none
LOG=y
R=verwaest@chromium.org,bmeurer@chromium.org,rossberg@chromium.org
==========

to

==========
Map v8::Function to JSReceiver + IsCallable

BUG=none
LOG=y
R=verwaest@chromium.org,bmeurer@chromium.org,rossberg@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng
==========

[jochen (gone - plz use gerrit), 2015-10-23 11:29:49]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2015-10-23 11:30:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1423723002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1423723002/40001

[commit-bot: I haz the power, 2015-10-23 12:26:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-23 12:27:18]

Patchset 3 (id:??) landed as
https://crrev.com/5587656155b1f7d6eff7894c39d89246cf84b94a
Cr-Commit-Position: refs/heads/master@{#31519}